Admin: a friendlier, segmented feed form - #121
Merged
Merged
Conversation
The feed create/edit form rendered as a flat stack of fields. Point the resource's vars.templates.form at a custom @SetonoSyliusFeedPlugin/admin/feed/_form.html.twig that: - groups fields into Semantic UI segments with dividing section headers (Details / Output / Sources / Delivery targets), laid out in a two-column stackable grid for the compact fields and full width for the wide collections; - renders the name/slug translations through Sylius' translationForm macro (the per-locale accordion) instead of a flat list; - adds sub-header help under the Sources and Delivery targets sections. New ui.* translation keys (details/output/translations/sources_help/delivery_targets_help). Browser-verified: renders, the translations accordion + all four collection add buttons work, and the form still submits and persists.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 1.x #121 +/- ##
=========================================
Coverage 92.17% 92.17%
Complexity 1727 1727
=========================================
Files 228 228
Lines 4382 4382
=========================================
Hits 4039 4039
Misses 343 343 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The feed create/edit form was a flat stack of fields. This points the resource's
vars.templates.format a custom_form.html.twigthat:translationFormmacro (the per-locale accordion) instead of a flat list;Browser-verified against the running test app: the page renders, the translations accordion (8 locales) and all four collection add buttons work, and the form still submits and persists. No PHP changed.