test(tinytorch): regression coverage for milestone grading/gating logic - #5
Merged
Conversation
… logic Covers the milestone system's core decision logic, previously exercised only by slow end-to-end runs that couldn't isolate individual conditions: the can_unlock gate, _module_progress_to_int's four input-type paths, _validate_required_exports' ImportError branch, _handle_run_command's non-interactive continue-on-failure abort path, and milestone 05's passed1/passed2/passed3 grading logic in print_final_results. Pure regression tests, no source or package files touched. Each test was verified against a clean origin/dev checkout before being added.
Shashank-Tripathi-07
force-pushed
the
mcdc-05-milestones
branch
from
August 14, 2026 23:36
72c3016 to
9a8dcba
Compare
Shashank-Tripathi-07
force-pushed
the
mcdc-04-systems-perf
branch
from
August 14, 2026 23:36
dbfa704 to
a469935
Compare
This was referenced Aug 14, 2026
|
Thanks @Shashank-Tripathi-07! 🎉 @Shashank-Tripathi-07 was already credited in tinytorch for: code, test. The contributor tables are now handled directly by this workflow; no follow-up command is needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds regression tests for the milestone system's grading/gating logic found by an MC/DC audit, previously exercised only by slow end-to-end runs that couldn't isolate individual conditions. Independent of the other companion PRs in this series (#1, #2, #3, #4), each covers a different module group and can be reviewed/merged in any order.
Covered gaps:
can_unlockgate (MilestoneSystem)_module_progress_to_int's four input-type paths_validate_required_exports'sImportErrorbranch_handle_run_command's non-interactive continue-on-failure abort pathpassed1/passed2/passed3grading logic inprint_final_resultsPure regression tests, no source or package files touched.
Test plan
pytest tests/cli/test_release_regressions.py tests/milestones -qpasses locally, including all new cases