Skip to content

Cookbook: markets fixes#2938

Merged
ruggishop merged 9 commits intomainfrom
feat/cookbook-markets-fixes
May 20, 2025
Merged

Cookbook: markets fixes#2938
ruggishop merged 9 commits intomainfrom
feat/cookbook-markets-fixes

Conversation

@ruggishop
Copy link
Copy Markdown
Contributor

@ruggishop ruggishop commented May 19, 2025

WHY are these changes introduced?

The markets recipe needs some adjustments.

WHAT is this pull request doing?

  1. Trim down the diff on root for the context passing, making it less redundant
  2. Add a list of supported locales, returning a 404 if there's no match
  3. Adjust the Link component for the default locale
  4. Update the sitemap file
  5. Add 404 management for invalid locales

Checklist

  • I've read the Contributing Guidelines
  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've added a changeset if this PR contains user-facing or noteworthy changes
  • I've added tests to cover my changes
  • I've added or updated the documentation

@shopify
Copy link
Copy Markdown
Contributor

shopify bot commented May 19, 2025

Oxygen deployed a preview of your feat/cookbook-markets-fixes branch. Details:

Storefront Status Preview link Deployment details Last update (UTC)
classic-remix ✅ Successful (Logs) Preview deployment Inspect deployment May 19, 2025 7:20 PM
custom-cart-method ✅ Successful (Logs) Preview deployment Inspect deployment May 20, 2025 9:20 AM
metaobjects ✅ Successful (Logs) Preview deployment Inspect deployment May 20, 2025 9:20 AM
third-party-queries-caching ✅ Successful (Logs) Preview deployment Inspect deployment May 20, 2025 9:20 AM
Skeleton (skeleton.hydrogen.shop) ✅ Successful (Logs) Preview deployment Inspect deployment May 20, 2025 9:20 AM

Learn more about Hydrogen's GitHub integration.

@ruggishop ruggishop marked this pull request as ready for review May 19, 2025 14:55
@ruggishop ruggishop force-pushed the feat/cookbook-markets-fixes branch from 0d5a7df to f69fac3 Compare May 19, 2025 19:18
Copy link
Copy Markdown
Contributor

@blittle blittle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@ruggishop ruggishop merged commit 3e9e0e5 into main May 20, 2025
10 checks passed
@ruggishop ruggishop deleted the feat/cookbook-markets-fixes branch May 20, 2025 16:59
juanpprieto pushed a commit that referenced this pull request Sep 17, 2025
* fix link component, redirect if invalid locale detected

* trim down diff

* define supported locales, 404 if not supported

* update sitemap

* 404 route, regen

* update copy

* add llm items

* regen
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants