AAAA NOOO the skeleton .gitignore needs a new CLI release#2952
Merged
balazsbajorics merged 2 commits intomainfrom May 21, 2025
Merged
AAAA NOOO the skeleton .gitignore needs a new CLI release#2952balazsbajorics merged 2 commits intomainfrom
balazsbajorics merged 2 commits intomainfrom
Conversation
Contributor
|
Oxygen deployed a preview of your
Learn more about Hydrogen's GitHub integration. |
rbshop
approved these changes
May 21, 2025
Merged
juanpprieto
pushed a commit
that referenced
this pull request
Sep 17, 2025
* adding .react-router to the gitignore generated by the cli * add changeset entry
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem:
Turns out
/templates/skeleton/.gitignoreis NOT the .gitignore file that is placed in a freshly generated Hydrogen store.Which means, new hydrogen stores created with the current CLI will not have
.react-routerin their gitignore files, which means, runningnpm run codegenwill create a messy git diff for our users.Fix
Place
.react-routerin the source string for the generated.gitignore. Merge this, then bump the shopify CLI.