Replace deprecated faker.internet.color() with faker.color.rgb()#2985
Merged
juanpprieto merged 2 commits intoShopify:mainfrom Aug 21, 2025
emmanuel-ferdman:main
Merged
Replace deprecated faker.internet.color() with faker.color.rgb()#2985juanpprieto merged 2 commits intoShopify:mainfrom emmanuel-ferdman:main
faker.internet.color() with faker.color.rgb()#2985juanpprieto merged 2 commits intoShopify:mainfrom
emmanuel-ferdman:main
Conversation
Signed-off-by: Emmanuel Ferdman <emmanuelferdman@gmail.com>
Contributor
|
Oxygen deployed a preview of your
Learn more about Hydrogen's GitHub integration. |
gbalint
approved these changes
Jun 26, 2025
Contributor
|
@emmanuel-ferdman please add a changeset for a |
Signed-off-by: Emmanuel Ferdman <emmanuelferdman@gmail.com>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates deprecated Faker.js API usage to resolve CI deprecation warnings by replacing faker.internet.color() with the recommended faker.color.rgb() method.
- Replaced deprecated
faker.internet.color()withfaker.color.rgb()in test helper - Added changeset to document the API update
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/hydrogen-react/src/parse-metafield.test.helpers.ts | Updated faker method call from deprecated internet.color() to color.rgb() |
| .changeset/tender-jeans-build.md | Added changeset documenting the faker API update |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Closed
This was referenced Sep 11, 2025
Closed
Merged
juanpprieto
pushed a commit
that referenced
this pull request
Sep 17, 2025
…2985) * Replace deprecated `faker.internet.color()` with `faker.color.rgb()` Signed-off-by: Emmanuel Ferdman <emmanuelferdman@gmail.com> * Replace deprecated `faker.internet.color()` with `faker.color.rgb()` Signed-off-by: Emmanuel Ferdman <emmanuelferdman@gmail.com> --------- Signed-off-by: Emmanuel Ferdman <emmanuelferdman@gmail.com>
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
This small PR replaces the deprecated
faker.internet.color()with the recommendedfaker.color.rgb()to resolve deprecation warnings which you can find in the CI logs:Checklist