test(e2e): comment out perf-kit assertions blocked by bot detection#3657
Merged
test(e2e): comment out perf-kit assertions blocked by bot detection#3657
Conversation
Perf-kit produce requests are blocked by Shopify's bot detection system, causing verifyPerfKitRequests() to fail in 4 cookie e2e tests. The perf-kit script itself loads fine, but its outgoing /v1/produce analytics requests never fire. The fix is server-side (outside Hydrogen) and in progress. Comment out the verifyPerfKitRequests assertions and their immediate setup (finalizePerfKitMetrics, waitForTimeout) with TODO markers so they can be re-enabled once the bot detection fix ships. Other perf-kit calls (waitForPerfKit, expectPerfKitLoaded) are left intact since they test script loading behavior and are currently passing. Co-Authored-By: Claude <noreply@anthropic.com>
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
5 tasks
Contributor
|
Oxygen deployed a preview of your
Learn more about Hydrogen's GitHub integration. |
lucyxiang
approved these changes
Apr 1, 2026
Contributor
lucyxiang
left a comment
lucyxiang
left a comment
There was a problem hiding this comment.
Ah this was failing on my PR, thanks
kdaviduik
force-pushed
the
kd-disable-perfkit-assertions
branch
from
d54847c to
5606796
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
4 cookie e2e tests (
consent-tracking-acceptandprivacy-banner-acceptin bothnew-cookiesandold-cookies) are failing in CI and locally. The failures are atverifyPerfKitRequests— perf-kit produce requests are blocked by Shopify's bot detection system. The perf-kit script itself loads fine, but its outgoing/v1/produceanalytics requests never fire.The bot detection fix is server-side (outside Hydrogen) and in progress separately.
WHAT is this pull request doing?
Comments out
verifyPerfKitRequests()and its immediate setup (finalizePerfKitMetrics(),waitForTimeout(500)) in the 4 failing specs with TODO markers for re-enablement once the server-side fix ships.Other perf-kit calls (
waitForPerfKit,expectPerfKitLoaded,expectPerfKitNotLoaded) are left intact — they test script loading behavior and are currently passing.HOW to test your changes?
npx playwright test --project=new-cookies --project=old-cookiesThe 4 previously-failing tests should now pass.
grep -r "storefront.verifyPerfKitRequests" e2e/specs/should return zero uncommented matches.Checklist
Co-Authored-By: Claude noreply@anthropic.com