Missing return in map callback and stray semicolon in ProductProvider#3680
Open
J8118 wants to merge 1 commit intoShopify:mainfrom
Open
Missing return in map callback and stray semicolon in ProductProvider#3680J8118 wants to merge 1 commit intoShopify:mainfrom
J8118 wants to merge 1 commit intoShopify:mainfrom
Conversation
…ider example The .map() callback used a block body without return, so buttons never rendered. Also removed a stray semicolon that would render as visible text. Fixed in both TypeScript and JavaScript examples.
Author
|
I have signed the CLA! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Title
Fix missing return in map callback and stray semicolon in ProductProvider example
Description
Summary
Two bugs in the
UsingProduct()function of both TypeScript and JavaScript ProductProvider examples:Missing
returnin.map()callback — The callback uses a block body{ }but has noreturnbefore the<button>JSX, so the.map()always produces an array ofundefinedand no buttons render. Fixed by switching to a concise arrow function body with( ).Stray semicolon — A lone
;on line 22 (tsx) / line 21 (jsx) sits between the closing})}of the map and the</>fragment close. This renders as visible text (a literal semicolon character) in the output.These example files are used to generate documentation on Shopify.dev.