Fix "uncommited" typo to "uncommitted" in deploy command#3684
Open
J8118 wants to merge 1 commit intoShopify:mainfrom
Open
Fix "uncommited" typo to "uncommitted" in deploy command#3684J8118 wants to merge 1 commit intoShopify:mainfrom
J8118 wants to merge 1 commit intoShopify:mainfrom
Conversation
Fix misspelling in 3 user-facing flag descriptions and 1 local variable name. The test file (deploy.test.ts:382) already uses the correct spelling "uncommitted".
Author
|
I have signed the CLA! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Title
Fix "uncommited" typo to "uncommitted" in deploy command
Description
Summary
The word "uncommited" (missing a "t") appears in 3 user-facing strings and 1 local variable name in the
hydrogen deploycommand. The test file (deploy.test.ts:382) already uses the correct spelling "uncommitted", confirming this is a typo rather than an intentional choice.Files changed:
packages/cli/src/commands/hydrogen/deploy.ts— 3 string fixes + 1 variable renameChanges:
'Forces a deployment to proceed if there are uncommited changes'→'uncommitted changes''if there are no uncommited changes.'→'no uncommitted changes.'forceOnUncommitedChanges→forceOnUncommittedChanges(local destructured variable)'Deploying uncommited changes'→'Deploying uncommitted changes'Note:
oclif.manifest.jsonalso contains this typo but is auto-generated from command definitions and will self-correct on next build.Test plan
forceOnUncommitedChangesis a local destructuring alias (line 253) used only on line 275 — no external API surface affecteddeploy.test.ts:382already uses "uncommitted" spelling