Fix merchandise {is: string} typo to {id: string} in useOptimisticCart#3687
Open
J8118 wants to merge 1 commit intoShopify:mainfrom
Open
Fix merchandise {is: string} typo to {id: string} in useOptimisticCart#3687J8118 wants to merge 1 commit intoShopify:mainfrom
J8118 wants to merge 1 commit intoShopify:mainfrom
Conversation
The default generic type parameter had a single-character typo:
merchandise: {is: string} instead of merchandise: {id: string}.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Title
Fix
merchandise: {is: string}typo to{id: string}in useOptimisticCartDescription
Summary
The default generic type parameter for
useOptimisticCarthasmerchandise: {is: string}on line 50, which should bemerchandise: {id: string}. This is a single-character typo (isvsid) in the TypeScript generic default.This affects consumers who rely on the default type parameter (i.e., don't pass an explicit type argument to
useOptimisticCart). TypeScript won't correctly type-checkmerchandise.idaccesses when using the default generic.File changed:
packages/hydrogen/src/cart/optimistic/useOptimisticCart.tsx(line 50)Before:
After: