Fix "Makerts" typo and use toLowerCase in markets setup message#3695
Open
J8118 wants to merge 1 commit intoShopify:mainfrom
Open
Fix "Makerts" typo and use toLowerCase in markets setup message#3695J8118 wants to merge 1 commit intoShopify:mainfrom
J8118 wants to merge 1 commit intoShopify:mainfrom
Conversation
Fix "Makerts" to "Markets" in the success headline. Also change toLocaleLowerCase() to toLowerCase() since strategy names are technical identifiers that should not be affected by system locale.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two issues in
setup/markets.tsline 68-70:.toLocaleLowerCase()— uses system locale for case conversion, which can produce wrong results on non-English systems (e.g., Turkish locale convertsItoıinstead ofi). Since these are technical strategy names,.toLowerCase()is correct.File changed:
packages/cli/src/commands/hydrogen/setup/markets.ts(lines 68-70)Before:
After: