Skip to content

fix: ssr.optimizeDeps dependency resolution warnings with pnpm dev #3698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
fredericoo wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

fix: ssr.optimizeDeps dependency resolution warnings with pnpm dev #3698

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8b1e8d1
fix(skeleton): resolve ssr.optimizeDeps dependency warnings
fredericoo Apr 10, 2026
ef6d10f
fix(cookbook): update recipe patches for new optimizeDeps format
fredericoo Apr 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .changeset/fix-skeleton-optimizedeps.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
---
'skeleton': patch
'@shopify/cli-hydrogen': patch
'@shopify/create-hydrogen': patch
---

Fix `set-cookie-parser` and `cookie` resolution warnings during `dev` by using Vite's nested dependency syntax (`react-router > dep`). These are CJS transitive dependencies of `react-router` that weren't resolvable by bare name with strict package managers like pnpm.
6 changes: 5 additions & 1 deletion cookbook/llms/express.prompt.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2546,7 +2546,11 @@ Configure Vite for Express deployment with Node.js module externalization
* Include 'example-dep' in the array below.
* @see https://vitejs.dev/config/dep-optimization-options
*/
- include: ['set-cookie-parser', 'cookie', 'react-router'],
- include: [
- 'react-router > set-cookie-parser',
- 'react-router > cookie',
- 'react-router',
- ],
+ include: ['@react-router/node', '@react-router/express'],
},
},
Expand Down
13 changes: 11 additions & 2 deletions cookbook/llms/multipass.prompt.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3540,8 +3540,17 @@ Configure Vite for crypto polyfills
* Include 'example-dep' in the array below.
* @see https://vitejs.dev/config/dep-optimization-options
*/
- include: ['set-cookie-parser', 'cookie', 'react-router'],
+ include: ['set-cookie-parser', 'cookie', 'react-router', 'crypto-js'],
- include: [
- 'react-router > set-cookie-parser',
- 'react-router > cookie',
- 'react-router',
- ],
+ include: [
+ 'react-router > set-cookie-parser',
+ 'react-router > cookie',
+ 'react-router',
+ 'crypto-js',
+ ],
},
},
server: {
Expand Down
10 changes: 7 additions & 3 deletions cookbook/llms/partytown.prompt.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -683,10 +683,14 @@ Configure Vite to exclude Partytown library from build optimization.
* Include 'example-dep' in the array below.
* @see https://vitejs.dev/config/dep-optimization-options
*/
- include: ['set-cookie-parser', 'cookie', 'react-router'],
- include: [
- 'react-router > set-cookie-parser',
- 'react-router > cookie',
- 'react-router',
- ],
+ include: [
+ 'set-cookie-parser',
+ 'cookie',
+ 'react-router > set-cookie-parser',
+ 'react-router > cookie',
+ 'react-router',
+ '@qwik.dev/partytown/react',
+ ],
Expand Down
6 changes: 5 additions & 1 deletion cookbook/recipes/express/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2636,7 +2636,11 @@ index a1702446..058b559d 100644
* Include 'example-dep' in the array below.
* @see https://vitejs.dev/config/dep-optimization-options
*/
- include: ['set-cookie-parser', 'cookie', 'react-router'],
- include: [
- 'react-router > set-cookie-parser',
- 'react-router > cookie',
- 'react-router',
- ],
+ include: ['@react-router/node', '@react-router/express'],
},
},
Expand Down
10 changes: 7 additions & 3 deletions cookbook/recipes/express/patches/vite.config.ts.63904f.patch
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ index 050b6ed7..ef18f2fc 100644
-import {oxygen} from '@shopify/mini-oxygen/vite';
import {reactRouter} from '@react-router/dev/vite';
import tsconfigPaths from 'vite-tsconfig-paths';

export default defineConfig({
- plugins: [hydrogen(), oxygen(), reactRouter(), tsconfigPaths()],
+ plugins: [hydrogen(), reactRouter(), tsconfigPaths()],
Expand All @@ -22,11 +22,15 @@ index 050b6ed7..ef18f2fc 100644
optimizeDeps: {
/**
* Include dependencies here if they throw CJS<>ESM errors.
@@ -23,10 +24,7 @@ export default defineConfig({
@@ -23,14 +24,7 @@ export default defineConfig({
* Include 'example-dep' in the array below.
* @see https://vitejs.dev/config/dep-optimization-options
*/
- include: ['set-cookie-parser', 'cookie', 'react-router'],
- include: [
- 'react-router > set-cookie-parser',
- 'react-router > cookie',
- 'react-router',
- ],
+ include: ['@react-router/node', '@react-router/express'],
},
},
Expand Down
13 changes: 11 additions & 2 deletions cookbook/recipes/multipass/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3760,8 +3760,17 @@ index 050b6ed7..14ae8119 100644
* Include 'example-dep' in the array below.
* @see https://vitejs.dev/config/dep-optimization-options
*/
- include: ['set-cookie-parser', 'cookie', 'react-router'],
+ include: ['set-cookie-parser', 'cookie', 'react-router', 'crypto-js'],
- include: [
- 'react-router > set-cookie-parser',
- 'react-router > cookie',
- 'react-router',
- ],
+ include: [
+ 'react-router > set-cookie-parser',
+ 'react-router > cookie',
+ 'react-router',
+ 'crypto-js',
+ ],
},
},
server: {
Expand Down
15 changes: 12 additions & 3 deletions cookbook/recipes/multipass/patches/vite.config.ts.63904f.patch
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,21 @@
index 050b6ed7..14ae8119 100644
--- a/templates/skeleton/vite.config.ts
+++ b/templates/skeleton/vite.config.ts
@@ -23,7 +23,7 @@ export default defineConfig({
@@ -23,11 +23,12 @@ export default defineConfig({
* Include 'example-dep' in the array below.
* @see https://vitejs.dev/config/dep-optimization-options
*/
- include: ['set-cookie-parser', 'cookie', 'react-router'],
+ include: ['set-cookie-parser', 'cookie', 'react-router', 'crypto-js'],
- include: [
- 'react-router > set-cookie-parser',
- 'react-router > cookie',
- 'react-router',
- ],
+ include: [
+ 'react-router > set-cookie-parser',
+ 'react-router > cookie',
+ 'react-router',
+ 'crypto-js',
+ ],
},
},
server: {
10 changes: 7 additions & 3 deletions cookbook/recipes/partytown/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -693,10 +693,14 @@ index a1702446..a2e3dda9 100644
* Include 'example-dep' in the array below.
* @see https://vitejs.dev/config/dep-optimization-options
*/
- include: ['set-cookie-parser', 'cookie', 'react-router'],
- include: [
- 'react-router > set-cookie-parser',
- 'react-router > cookie',
- 'react-router',
- ],
+ include: [
+ 'set-cookie-parser',
+ 'cookie',
+ 'react-router > set-cookie-parser',
+ 'react-router > cookie',
+ 'react-router',
+ '@qwik.dev/partytown/react',
+ ],
Expand Down
12 changes: 8 additions & 4 deletions cookbook/recipes/partytown/patches/vite.config.ts.63904f.patch
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,18 @@
index 050b6ed7..77b27fae 100644
--- a/templates/skeleton/vite.config.ts
+++ b/templates/skeleton/vite.config.ts
@@ -23,7 +23,12 @@ export default defineConfig({
@@ -23,11 +23,12 @@ export default defineConfig({
* Include 'example-dep' in the array below.
* @see https://vitejs.dev/config/dep-optimization-options
*/
- include: ['set-cookie-parser', 'cookie', 'react-router'],
- include: [
- 'react-router > set-cookie-parser',
- 'react-router > cookie',
- 'react-router',
- ],
+ include: [
+ 'set-cookie-parser',
+ 'cookie',
+ 'react-router > set-cookie-parser',
+ 'react-router > cookie',
+ 'react-router',
+ '@qwik.dev/partytown/react',
+ ],
Expand Down
6 changes: 5 additions & 1 deletion templates/skeleton/vite.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,11 @@ export default defineConfig({
* Include 'example-dep' in the array below.
* @see https://vitejs.dev/config/dep-optimization-options
*/
include: ['set-cookie-parser', 'cookie', 'react-router'],
include: [
'react-router > set-cookie-parser',
'react-router > cookie',
'react-router',
],
},
},
server: {
Expand Down
Loading