doc: add example with arguments to `each_iteration#221
doc: add example with arguments to `each_iteration#221fwolfst wants to merge 1 commit intoShopify:mainfrom
Conversation
ghost
added
the
etiennebarrie
left a comment
etiennebarrie
left a comment
There was a problem hiding this comment.
The BatchesJob and BatchesAsRelationJob already pass additional arguments. Your added class doesn't really add much to that. Maybe if we just had an additional sentence before the example that would be more explicit. By the way the CSV example should be fixed because it passes an argument to build_enumerator which is not passed to each_iteration.
| ) | ||
| end | ||
|
|
||
| # addtional arguments as in #build_enumerator (except the cursor) |
Whatever solves #220 . I really find the example and the verbal explanations lacking (for this aspect). Also, my example makes explicit that you might need different stuff to create the enumerator and how to deal with that situation. Should I include the csv and typo-fix and sign the CLA or will this issue not be solved via this PR? |
|
Yes sorry I wasn't clear, this is great, adding more explicit verbal explanation right before your added example is a great idea and I will merge this 👍 |
2 participants
fixes #220