Skip to content
This repository was archived by the owner on Oct 30, 2024. It is now read-only.

fix unmarshal errors not found for known k8s schema#571

Open
fedeztk wants to merge 1 commit intoShopify:mainfrom
fedeztk:fix-unmarshal-error-not-found
Open

fix unmarshal errors not found for known k8s schema#571
fedeztk wants to merge 1 commit intoShopify:mainfrom
fedeztk:fix-unmarshal-error-not-found

Conversation

@fedeztk
Copy link
Copy Markdown

@fedeztk fedeztk commented Sep 1, 2023

Description

Fixes #523 (known schema not raising errors when incompatible with k8s resource definitions)

Type of change
  • Bug fix 🐛
  • New feature ✨
  • This change requires a documentation update 📖
  • Breaking changes ⚠️
How Has This Been Tested?

Tested using the example provided in #523. Prior to this change there was no error; now, known resources (e.g. Deployments) raise an error when the unmarshaling goes wrong (like unquoted labels) and clearly shows that there is a misconfiguration in the manifest.

Checklist:
  • I have 🎩 my changes (A 🎩 specifically includes pulling down changes, setting them up, and manually testing the changed features and potential side effects to make sure nothing is broken)
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • The test coverage did not decrease
  • I have signed the appropriate Contributor License Agreement

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Not finding errors in deployment

1 participant