This repository was archived by the owner on Oct 30, 2024. It is now read-only.
fix unmarshal errors not found for known k8s schema#571
Open
fedeztk wants to merge 1 commit intoShopify:mainfrom
Open
fix unmarshal errors not found for known k8s schema#571fedeztk wants to merge 1 commit intoShopify:mainfrom
fedeztk wants to merge 1 commit intoShopify:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #523 (known schema not raising errors when incompatible with k8s resource definitions)
Type of change
How Has This Been Tested?
Tested using the example provided in #523. Prior to this change there was no error; now, known resources (e.g. Deployments) raise an error when the unmarshaling goes wrong (like unquoted labels) and clearly shows that there is a misconfiguration in the manifest.
Checklist: