Replace manual #copy with standard #dup#889
Merged
amomchilov merged 1 commit intomainfrom Apr 2, 2026
Merged
Conversation
amomchilov
commented
Apr 1, 2026
| def allowed_extensions=(_arg0); end | ||
|
|
||
| sig { returns(::Spoom::Sorbet::Config) } | ||
| def copy; end |
Contributor
Author
There was a problem hiding this comment.
Is this considered a breaking change? Is this API public?
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Morriar
reviewed
Apr 1, 2026
| new_config.no_stdlib = @no_stdlib | ||
| new_config | ||
| #: (Config source) -> void | ||
| def initialize_copy(source) |
Contributor
Author
There was a problem hiding this comment.
Yes, otherwise the dup has shallow-copy semantics (arrays are shared). This makes it a deep copy (which is how #copy behaved).
Morriar
approved these changes
Apr 2, 2026
Morriar
approved these changes
Apr 2, 2026
| def allowed_extensions=(_arg0); end | ||
|
|
||
| sig { returns(::Spoom::Sorbet::Config) } | ||
| def copy; end |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.