Merged
Conversation
vinistock
approved these changes
Apr 1, 2026
paracycle
approved these changes
Apr 1, 2026
Morriar
reviewed
Apr 1, 2026
| end | ||
| e = assert_raises(NameError) { rbi_for(:Post) } | ||
|
|
||
| assert_match("uninitialized constant Post::User", e.message) |
Contributor
There was a problem hiding this comment.
Looks like assert_match will create a regexp anyway:
pattern = case(pattern)
when String
Regexp.new(Regexp.escape(pattern))
else
pattern
endWouldn't passing a literal regexp with /pattern/ be slightly faster and more memory efficient?
Contributor
Author
There was a problem hiding this comment.
AHaha i saw this change and had an inkling you might flag this. Won't someone think of the bytes?!
If it needs escaping, I'll keep the string format, because it's much easier to read without the backslashes (e.g. /sig \{ returns\(void\)\) \}/)
48e30d4 to
7c6c7d6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
These calls are trying to pass a String/Regex as a matcher, but it's actually just interpreted as an exception type to try to rescue. It's confusing the base Minitest version of
assert_raises(*exp)for the augment Railsassert_raises(*exp, match:).