Allow refactor label to meet CI requirement#2573
Conversation
| "bugfix", | ||
| "chore", | ||
| "enhancement", | ||
| "refactor", |
There was a problem hiding this comment.
This on its own isn't enough, we need to also classify the tag to feed into one of the release categories here: https://github.com/Shopify/tapioca/blob/main/.github/release.yml#L10-L23
Actually, maybe, instead of manually maintaining this list, we should just check against the union of labels for all the categories
There was a problem hiding this comment.
We could continue using chore for this as it doesn't bring much value for end users
There was a problem hiding this comment.
I can also see us adding refactor to the exclude list.
There was a problem hiding this comment.
I like adding it to the exclude list.
amomchilov
changed the title
refactor label to meet requirementrefactor label to meet CI requirement
This error will always be triggered on community contributed PRs, whose authors wouldn't have the access level necessary to label it themselves.
amomchilov
force-pushed
the
Alex/allow-refactor-label
branch
from
ee8dab8 to
9b7619d
Compare
|
|
||
| if matching_labels.empty? | ||
| warn("PR is missing at least one of the following labels: #{REQUIRED_LABELS.join(", ")}") | ||
| warn <<~MSG |
There was a problem hiding this comment.
This error will always be triggered on community contributed PRs, whose authors wouldn't have the access level necessary to label it themselves.
We talked about this with the team a while ago, and didn't have a good solution. For now, let's at least give more clear instruction.
3 participants
Motivation
It's pretty reasonable to have a PR that's just labelled refactor. Right now, the CI would force you to tag it with something else like
choreorenhancement, which aren't necessarily a good fit.