Skip to content

strengthen - #216

Open
yika-aixi wants to merge 73 commits into
Siccity:masterfrom
yika-aixi:Cabin_Icarus
Open

strengthen#216
yika-aixi wants to merge 73 commits into
Siccity:masterfrom
yika-aixi:Cabin_Icarus

Conversation

@yika-aixi

Copy link
Copy Markdown

multi Node Window

treeviewMenu

DynamicPortList Do not force index latent rules
supportRenameList

@Siccity

Siccity commented Dec 15, 2019

Copy link
Copy Markdown
Owner

You have a lot of neat features here. Please follow contributing guidelines if you wish to contribute

@yika-aixi

Copy link
Copy Markdown
Author

You have a lot of neat features here. Please follow contributing guidelines if you wish to contribute

OK, let me see

@yika-aixi

Copy link
Copy Markdown
Author

I standardized the naming and removed duplicate implementations.You review, it is not very convenient to split the submission.I need to create many branches to extract commits.

@Siccity

Siccity commented Dec 23, 2019

Copy link
Copy Markdown
Owner

I'm sorry, but this PR will take a very long time to review, and thus it will not be merged.
I will keep it around as an open PR for future reference.
Some immediate issues is the removal of .meta files and the inconsistent code formatting.

@yika-aixi

Copy link
Copy Markdown
Author

I'm sorry, but this PR will take a very long time to review, and thus it will not be merged.
I will keep it around as an open PR for future reference.
Some immediate issues is the removal of .meta files and the inconsistent code formatting.

meta file was deleted is because no in the library any scripts to be referenced, so I deleted him

@yika-aixi

Copy link
Copy Markdown
Author

I'm sorry, but this PR will take a very long time to review, and thus it will not be merged.
I will keep it around as an open PR for future reference.
Some immediate issues is the removal of .meta files and the inconsistent code formatting.

Code format, I look at the code, I may have forgotten to change it, sorry

# Conflicts:
#	Scripts/Editor/NodeEditorWindow.cs
# Conflicts:
#	.gitignore
#	Scripts/Editor/NodeEditor.cs
#	Scripts/Editor/NodeEditorAction.cs
#	Scripts/Editor/NodeEditorGUILayout.cs
#	Scripts/Editor/NodeGraphEditor.cs
#	Scripts/NodeDataCache.cs
@AKJ1

AKJ1 commented Jun 26, 2020

Copy link
Copy Markdown

Woah, this is a wild PR. yika's branch is usable with 2019.4 LTS and fixes #117, for any googlers that end up searching for a solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants