feat: add 6 new sigmahq validators - #78
Closed
frack113 wants to merge 14 commits into
Closed
Conversation
Checks if rule titles contain trademarked terms ('MITRE ATT&CK', 'ATT&CK')
that should not be used.
Checks if a detection contains 'source: eventlog' which is redundant. Uses recursive detection tree traversal to handle nested SigmaDetection.
Checks if a rule has a malformed 'license' field (must be a string). Skips correlation rules consistent with other sigmahq validators.
Checks if a rule uses EventID 1 or 4688 with Provider_Name (Microsoft-Windows-Security-Auditing, Microsoft-Windows-Sysmon) instead of the process_creation logsource category. Uses recursive detection tree traversal and case-insensitive field matching.
Checks if any selection has a list with only 1 element. Uses recursive detection tree traversal to handle nested SigmaDetection.
21 tests covering: - SigmahqTrademarkValidator (4 tests) - SigmahqSourceEventlogValidator (4 tests) - SigmahqLicenseValidator (4 tests) - SigmahqEventIdProcessCreationValidator (5 tests) - SigmahqSelectionSingleValueValidator (4 tests)
frack113
changed the title
frack113
marked this pull request as draft
August 14, 2026 11:32
Member
Author
|
Too mamy FP |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add 6 new validators to cover additional SigmaHQ rule conventions:
New Validators
sigmahq_trademarksigmahq_source_eventlogsigmahq_licensesigmahq_event_id_process_creationsigmahq_selection_single_valuesigmahq_selection_alphabetical_orderTests
Checklist