Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions sigma/types.py
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
from dataclasses import InitVar, dataclass, field
from enum import Enum, auto
from ipaddress import IPv4Network, IPv6Network, ip_network
from math import inf
from math import inf, isfinite
from typing import (
ClassVar,
Type,
Expand Down Expand Up @@ -669,13 +669,15 @@ class SigmaNumber(SigmaType):

def __post_init__(self, init_number: Any) -> None:
try: # Only use float number if it can't be represented as int.
i = int(init_number)
f = float(init_number)
if not isfinite(f):
raise ValueError("Invalid number")
i = int(init_number)
if i == f:
self.number = i
else:
self.number = f
except ValueError as e:
except (ValueError, OverflowError) as e:
raise SigmaValueError("Invalid number") from e

def __str__(self) -> str:
Expand Down
6 changes: 6 additions & 0 deletions tests/test_types.py
Original file line number Diff line number Diff line change
Expand Up @@ -569,6 +569,12 @@ def test_number_invalid():
SigmaNumber("test")


def test_number_invalid_non_finite():
for value in [float("inf"), float("-inf"), float("nan")]:
with pytest.raises(SigmaValueError, match="Invalid number"):
SigmaNumber(value)


def test_field_reference():
assert SigmaFieldReference("field").field == "field"

Expand Down