Skip to content

Reset notification for any state change, not just coming from normal state #3014

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
davidsanner wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Reset notification for any state change, not just coming from normal state #3014

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
af83973
Reset notification for any state change, not just coming from normal …
davidsanner Sep 4, 2026
3f04584
Merge branch 'SignalK:master' into davidsanner-reset-notification-ack
davidsanner Sep 9, 2026
98e3c18
Reset notification on escalating state only (and normal)
davidsanner Sep 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions src/api/notifications/alarm.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,10 +100,7 @@ export class Alarm {

this.parseDelta(update, context)

if (
prevState === ALARM_STATE.normal &&
this.value.state !== ALARM_STATE.normal
) {
if (prevState !== this.value.state){
this.status.acknowledged = false
delete this.status.acknowledgedAt
this.status.silenced = false
Expand Down
Loading