Skip to content

Fix Emitter memory leak #330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
RiskoZS wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

Fix Emitter memory leak #330

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
14d58e3
Fixes Emitter memory leak
RiskoZS Jan 10, 2022
4736f7e
Simplifies internal Emitter cleaning
RiskoZS Jan 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 5 additions & 9 deletions libs/utils/Emitter.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,21 +21,15 @@ local meta = {
end
}

local function mark(listeners, i)
listeners[i] = false
listeners.marked = true
end

local function clean(listeners)
for i = #listeners, 1, -1 do
if not listeners[i] then
remove(listeners, i)
end
end
listeners.marked = nil
end

local once = {}
local once = setmetatable({}, {__mode = "k"})

function Emitter:__init()
self._listeners = setmetatable({}, meta)
Expand All @@ -56,16 +50,18 @@ end

function Emitter:emit(eventName, ...)
local listeners = self._listeners[checkType('string', eventName)]
local needsCleaning = false
for i = 1, #listeners do
local listener = listeners[i]
if listener then
if once[listener] then
mark(listeners, i)
listeners[i] = false
needsCleaning = true
end
listener:fire(...)
end
end
if listeners.marked then
if needsCleaning then
clean(listeners)
end
end
Expand Down