Skip to content

Add glob for issue #26#32

Open
cybrown wants to merge 1 commit into
SitePen:masterfrom
cybrown:master
Open

Add glob for issue #26#32
cybrown wants to merge 1 commit into
SitePen:masterfrom
cybrown:master

Conversation

@cybrown

@cybrown cybrown commented Aug 11, 2015

Copy link
Copy Markdown

Add glob for files option, issue #26

@kitsonk

kitsonk commented Sep 3, 2015

Copy link
Copy Markdown
Contributor

@cybrown we require CLAs for any contributions as part of the Dojo Foundation. I was unable to find a CLA based on your GitHub username. Could you please take a moment to file a CLA or let me know what username or e-mail address you used?

@cybrown

cybrown commented Sep 3, 2015

Copy link
Copy Markdown
Author

This PR will be merged if I accept the CLA ?

@kitsonk kitsonk self-assigned this Sep 3, 2015
@kitsonk

kitsonk commented Sep 3, 2015

Copy link
Copy Markdown
Contributor

I haven't looked at it in detail, but it seems logical to me, so I will try to land it.

@cybrown

cybrown commented Sep 3, 2015

Copy link
Copy Markdown
Author

I've signed the CLA, with my gmail: cy.brown59

@kitsonk

kitsonk commented Sep 4, 2015

Copy link
Copy Markdown
Contributor

Cy Brown submitted a CLA on 2015-09-03 13:44:25.

@kitsonk

kitsonk commented Sep 18, 2015

Copy link
Copy Markdown
Contributor

@cybrown sorry for taking so long to have a look at this... Would ultimately reading the tsconfig.json work for solving this (assuming it supports properly the globs property available in tsconfig.json)?

@cybrown

cybrown commented Sep 29, 2015

Copy link
Copy Markdown
Author

I don't think that reading the tsconfig.json would be a good idea because I think that in most workflows, the generated .d.ts files are outputed in another directory, leaving the source directory clean.

@dylans dylans left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we'll go ahead and land this. It looks like there needs to be an adjustment to use tabs instead of spaces in a few lines of this PR.

@dylans dylans added this to the 2.1.0 milestone Jan 12, 2017
@dylans dylans modified the milestones: 2.2.0, 2.1.0 Jan 30, 2017
@dylans

dylans commented Jan 30, 2017

Copy link
Copy Markdown
Contributor

Pushing out to 2.2.0 as there are still changes to review.

@dylans dylans modified the milestones: 2.2.0, 3.0 Dec 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants