Refactor UI Panel Structure and Optimize Auction/Shop UI#1162
Conversation
- Redesigned `mainPanel` in `panelRegistry.ts` to directly present frequently used features (Shop, Auction House, Games, etc.) at the top, removing intermediate categories like `economyMainPanel` and `socialMainPanel`. - Relocated the 'Reset Settings' button in `configPanel.ts` to persistently appear at the very bottom of the admin Configuration panel list. - Improved the Auction House UI generation in `src/features/auction/ui/panel.ts` to use a dynamic array builder pattern instead of rigid and fragile offset calculations. - Fixed a bug in Shop User Panel pagination by ensuring the correct permission argument was provided to `addPaginationItems`. Co-authored-by: SjnExe <142050666+SjnExe@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
This pull request introduces a series of layout and structural improvements to the server's UI panels. These changes aim to make navigating the most frequently used systems easier for both players and staff.
Changes:
mainPanel(Main Menu):configResetPanel) button to appear strictly at the bottom of the config list for server admins.showAuctionHouse,showYourListings, andshowMailboxUI. Previously, buttons and selections were tracked using complex offset integers which were prone to bugs when layouts changed. They now utilize a cleaner array-mapping pattern.addPaginationItems) using the panel ID instead of the permission string, resolving a potential UI breakage.PR created automatically by Jules for task 11497863229978523783 started by @SjnExe