refactor: restructure UI panels for efficiency#1164
Merged
Conversation
- Redesigned `mainPanel` in `panelRegistry.ts` to directly present frequently used features (Shop, Auction House, Games, etc.) at the top, removing intermediate categories like `economyMainPanel` and `socialMainPanel`. - Relocated the 'Reset Settings' button in `configPanel.ts` to persistently appear at the very bottom of the admin Configuration panel list. - Improved the Auction House UI generation in `src/features/auction/ui/panel.ts` to use a dynamic array builder pattern instead of rigid and fragile offset calculations. - Fixed a bug in Shop User Panel pagination by ensuring the correct permission argument was provided to `addPaginationItems`. - Updated ItemSerializer.ts to use latest Minecraft Server beta APIs. Co-authored-by: SjnExe <142050666+SjnExe@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mainPanelinpanelRegistry.tsto directly present frequently used features (Shop, Auction House, Games, etc.) at the top, removing intermediate categories likeeconomyMainPanelandsocialMainPanel.configPanel.tsto persistently appear at the very bottom of the admin Configuration panel list.src/features/auction/ui/panel.tsto use a dynamic array builder pattern instead of rigid and fragile offset calculations.addPaginationItems.name: Pull Request
about: Propose changes to the AddonExe
title: 'Brief description of changes (e.g., Fix: Resolve fly detection false positive)'
Description of Changes:
How Has This Been Tested?
Screenshots / Video (for UI or visual changes):
Checklist:
By submitting this pull request, you agree to license your contribution under the project's MIT License.