Add catalog provider for postgres - #34
Merged
Merged
Conversation
reluctanthero104
changed the title
reluctanthero104
changed the title
reluctanthero104
force-pushed
the
add_catalog_provider_for_postgres
branch
2 times, most recently
from
March 30, 2026 13:53
d944463 to
5960499
Compare
reluctanthero104
changed the title
reluctanthero104
force-pushed
the
add_catalog_provider_for_postgres
branch
2 times, most recently
from
April 9, 2026 23:00
2dc42d0 to
fd15c1c
Compare
reluctanthero104
marked this pull request as ready for review
April 10, 2026 18:03
BtXin
reviewed
Apr 11, 2026
BtXin
left a comment
BtXin
left a comment
Contributor
There was a problem hiding this comment.
Code Review: Add catalog provider for Postgres
Overall
Well-structured PR. The decomposition of the monolithic register_postgres_tables into focused helpers (init_postgres_pools, build_postgres_table_provider, build_and_register_table, register_table_in_knn_registry) is clean and makes both code paths easy to follow. Config validation is solid, test coverage is thorough, and the README additions are excellent.
See inline comments for specific suggestions. Items #1 (import style) and #3 (credential logging) should be addressed before merge; the rest are improvements that could be follow-ups.
add demo h fix catalog bound update allowed schema fix test
reluctanthero104
force-pushed
the
add_catalog_provider_for_postgres
branch
from
April 11, 2026 19:31
4ee1ad1 to
c8b79b9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the support for catalog provider on postgres. Note that datafusion doesn't support schema provider registration, so we will only keep the hierarchy into table & catalog for now.