Added REPLACEABLE AOEMatchType#5094
Open
Insane96 wants to merge 2 commits into
Open
Conversation
Member
|
I feel like hardcoding another match type is the wrong solution. Adding a way for addons to add their own match types is a better approach. I dont believe that file you patched is the only place making use of the match type though. Look at the modifier hooks for inspiration on how to handle match types, seems like they need a function that maps |
This reverts commit e9d9ede.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm making a modifier to place blocks in the air, and Diyo wanted the placing area to match the tools AOE.
Currently this is not possible due to
AOEMatchTypefixed to harvestable or non-air blocks (BREAKINGorTRANSFORM), and for the mid air placing I need it to match replaceable blocks.