Skip to content

Fix issues with TextData lists that aren't prefixed#5668

Open
paypur wants to merge 3 commits into
SlimeKnights:1.20.1from
paypur:nobuild-html-mantle-test
Open

Fix issues with TextData lists that aren't prefixed#5668
paypur wants to merge 3 commits into
SlimeKnights:1.20.1from
paypur:nobuild-html-mantle-test

Conversation

@paypur

@paypur paypur commented Apr 28, 2026

Copy link
Copy Markdown
Contributor

3 6 lines

@paypur paypur changed the title html mantle test book Fix issues with TextData lists that aren't prefixed Apr 29, 2026
@paypur

paypur commented Apr 29, 2026

Copy link
Copy Markdown
Contributor Author

maybe these should be moved into a helper function

@KnightMiner KnightMiner changed the base branch from nobuild-html-book to 1.20.1 April 29, 2026 02:30
@KnightMiner

Copy link
Copy Markdown
Member

tbh, the margin top should probably be a CSS class. But yeah, helper function is also reasonable.

@paypur

paypur commented Apr 29, 2026

Copy link
Copy Markdown
Contributor Author

or maybe HtmlElement with a string or span descendant should just automatically wrap that with p when you serialize it

@KnightMiner

Copy link
Copy Markdown
Member

I'd rather not hardcode that. Its a style preference to wrap it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants