Open
Conversation
…on currentDisengagementOffset
Stermere
requested review from
ButterscotchV,
Eirenliel and
Erimelowo
as code owners
github-actions
bot
added
Area: Skeletal Model
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug that would cause floor-clip to not re-engage when the user returned to an upright pose from any pose where the hip was close enough to the floor to trigger the
isStandingfunction to return false.The logic that was removed here served to prevent any jumps in position as floor-clip was turning back on; however, in the current version of floor-clip, the
currentDisengagementOffsetvariable also serves to prevent jumps in position, making the former logic redundant besides the below scenarioOne potential downside of this is that there will always be a hard floor when using floor-clip, which means going down stairs or other vertical activities requiring the user to descend below their initial calibration position will behave unexpectedly. I feel this is an acceptable trade-off given a typical VR user's play space. This downside can be fixed with some changes to how
currentDisengagementOffsetis calculated.