Skip to content

Dispose the streams we create in HTTP generated code #539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Smaug123 merged 4 commits into from
Jul 8, 2026
Merged

Dispose the streams we create in HTTP generated code #539

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2feabc5
Dispose the streams we create in HTTP generated code
Smaug123 Jul 8, 2026
9456f0c
Taskify
Smaug123 Jul 8, 2026
9325f7d
Don't dispose caller-owned resources
Smaug123 Jul 8, 2026
1a375af
Fix the other tests
Smaug123 Jul 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
930 changes: 620 additions & 310 deletions ConsumePlugin/Generated2SwaggerGitea.fs
View file
Open in desktop

Large diffs are not rendered by default.

120 changes: 75 additions & 45 deletions ConsumePlugin/GeneratedRestClient.fs
View file
Open in desktop

Large diffs are not rendered by default.

18 changes: 12 additions & 6 deletions ConsumePlugin/GeneratedVault.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -537,14 +537,15 @@ module VaultClient =
)
)

let httpMessage =
use httpMessage =
new System.Net.Http.HttpRequestMessage (
Method = System.Net.Http.HttpMethod.Get,
RequestUri = uri
)

let! response = client.SendAsync (httpMessage, ct) |> Async.AwaitTask
let response = response.EnsureSuccessStatusCode ()
use response = response
let! responseStream = response.Content.ReadAsStreamAsync ct |> Async.AwaitTask

let! jsonNode =
Expand Down Expand Up @@ -582,14 +583,15 @@ module VaultClient =
System.Uri ("v1/auth/jwt/login", System.UriKind.Relative)
)

let httpMessage =
use httpMessage =
new System.Net.Http.HttpRequestMessage (
Method = System.Net.Http.HttpMethod.Get,
RequestUri = uri
)

let! response = client.SendAsync (httpMessage, ct) |> Async.AwaitTask
let response = response.EnsureSuccessStatusCode ()
use response = response
let! responseStream = response.Content.ReadAsStreamAsync ct |> Async.AwaitTask

let! jsonNode =
Expand Down Expand Up @@ -649,14 +651,15 @@ module VaultClientNonExtensionMethod =
)
)

let httpMessage =
use httpMessage =
new System.Net.Http.HttpRequestMessage (
Method = System.Net.Http.HttpMethod.Get,
RequestUri = uri
)

let! response = client.SendAsync (httpMessage, ct) |> Async.AwaitTask
let response = response.EnsureSuccessStatusCode ()
use response = response
let! responseStream = response.Content.ReadAsStreamAsync ct |> Async.AwaitTask

let! jsonNode =
Expand Down Expand Up @@ -694,14 +697,15 @@ module VaultClientNonExtensionMethod =
System.Uri ("v1/auth/jwt/login", System.UriKind.Relative)
)

let httpMessage =
use httpMessage =
new System.Net.Http.HttpRequestMessage (
Method = System.Net.Http.HttpMethod.Get,
RequestUri = uri
)

let! response = client.SendAsync (httpMessage, ct) |> Async.AwaitTask
let response = response.EnsureSuccessStatusCode ()
use response = response
let! responseStream = response.Content.ReadAsStreamAsync ct |> Async.AwaitTask

let! jsonNode =
Expand Down Expand Up @@ -764,14 +768,15 @@ module VaultClientExtensionMethodHttpClientExtension =
)
)

let httpMessage =
use httpMessage =
new System.Net.Http.HttpRequestMessage (
Method = System.Net.Http.HttpMethod.Get,
RequestUri = uri
)

let! response = client.SendAsync (httpMessage, ct) |> Async.AwaitTask
let response = response.EnsureSuccessStatusCode ()
use response = response
let! responseStream = response.Content.ReadAsStreamAsync ct |> Async.AwaitTask

let! jsonNode =
Expand Down Expand Up @@ -809,14 +814,15 @@ module VaultClientExtensionMethodHttpClientExtension =
System.Uri ("v1/auth/jwt/login", System.UriKind.Relative)
)

let httpMessage =
use httpMessage =
new System.Net.Http.HttpRequestMessage (
Method = System.Net.Http.HttpMethod.Get,
RequestUri = uri
)

let! response = client.SendAsync (httpMessage, ct) |> Async.AwaitTask
let response = response.EnsureSuccessStatusCode ()
use response = response
let! responseStream = response.Content.ReadAsStreamAsync ct |> Async.AwaitTask

let! jsonNode =
Expand Down
Loading
Loading