Honour the int64 integer format - #544
Merged
Merged
Conversation
This was referenced Jul 9, 2026
Smaug123
force-pushed
the
swagger-default-responses
branch
from
July 9, 2026 23:11
0859f3c to
a5c5159
Compare
All Swagger integer definitions rendered as F# int regardless of format, narrowing 64-bit IDs to Int32: overflow on the way out, rejection of valid responses on the way in. "format": "int64" now renders as int64 in both defnToType and renderType; other or absent formats remain int. E.g. IssueGetComments now takes index : int64 and Team.Id is int64 option. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Third fix split out of #540; stacked on #543.
All Swagger integer definitions rendered as F#
intregardless offormat, narrowing 64-bit IDs toInt32: overflow on the way out, rejection of otherwise-valid responses on the way in."format": "int64"now renders asint64in bothdefnToTypeandrenderType; other or absent formats remainint.In the generated Gitea client,
IssueGetCommentsnow takesindex : int64,Team.Idisint64 option, etc.Tests (
TestSwaggerTypeRender.fs) were written first and observed failing on the int64 cases; they drive both rendering paths directly over all three format cases.🤖 Generated with Claude Code