Record property accesses in capturing mocks - #547
Merged
Conversation
The capturing mock's Calls record has an entry per property, but the generated property implementations invoked only the configured function and never appended to those logs, so the call arrays stayed empty forever. Property getters now record into Calls under a lock, mirroring the method implementations. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…oofWare.Myriad into capturing-mock-property-calls
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Last fix split out of #540; independent of the Swagger stack (#542–#546) — it touches only the capturing-mock generator and its generated file, so it can merge in any order.
The capturing mock's
Callsrecord has an entry per property, but the generated property implementations invoked only the configured function and never appended to those logs, soCalls.Prop1/Calls.Prop2stayed empty forever. Property getters now record intoCallsunder a lock, mirroring the method implementations:Test was written first and observed failing (counts stayed at 0 after access).
🤖 Generated with Claude Code