Feature/edan verifier utility#531
Draft
EMaslowskiQ wants to merge 19 commits into
Draft
Conversation
* WIP commit for EDAN Verifier utility * cleaned out legacy code prior to refactor * limiting returned EDAN records to 1, otherwise throw error * fix issues with ARK ids not being outputted if also set to preferred * added basic determination of DPO vs. EDAN subject sources * support for name comparisons * support for updating Packrat units from EDAN
* using WorkflowEngine for running the EDAN verifier (WorkflowVerifier) * full support of query params for configuring verifier (accepts: objectId, limit, returnFile, detailedLogs) * HTTP response includes hyperlink for downloading the report * added 'Name' property to WorkflowReport to assist in filename creation
jahjedtieson
suggested changes
Jan 31, 2023
jahjedtieson
left a comment
jahjedtieson
left a comment
Contributor
There was a problem hiding this comment.
Your first PR! What a great milestone!
- The changes to server/tests/jest.config.js must not be committed. Doing so will disable regression tests from being run, by default, by other users, and by GitHub CI.
- We don't add server/db/sql/models/Packrat.mwb.bak to our source tree.
- server/utils/verifiers/VerifierBase.ts's replacePackratUnit() is doing the wrong thing. Instead of updating Unit records, it needs to update Subject.idUnit (i.e point the subject at the right unit).
- I've asked a number of inline questions/provided feedback.
| } | ||
|
|
||
| // if identifier exists in our database (value & type) then store it | ||
| const identifiers: DBAPI.Identifier[] | null = await DBAPI.Identifier.fetchFromIdentifierValue(content); |
Contributor
There was a problem hiding this comment.
I'm confused by the intention of this code. fetchFromIdentifierValue is going to get all identifiers that match the specified value ... this may include matches for identifiers with the same value, but applied to other system objects, and/or of random identifier types. In other words, identifiers are not guaranteed to have a unique value....
…ithsonian/dpo-packrat into feature/EDAN-verifier-utility
jahjedtieson
reviewed
Feb 1, 2023
jahjedtieson
left a comment
jahjedtieson
left a comment
Contributor
There was a problem hiding this comment.
Please remove server/db/sql/models/Packrat.mwb.bak from this PR.
EMaslowskiQ
force-pushed
the
develop
branch
2 times, most recently
from
008e5d6 to
aa7535c
Compare
EMaslowskiQ
force-pushed
the
develop
branch
2 times, most recently
from
ed431bd to
b0a38cd
Compare
EMaslowskiQ
force-pushed
the
feature/EDAN-verifier-utility
branch
from
756198b to
b645f4b
Compare
EMaslowskiQ
force-pushed
the
develop
branch
2 times, most recently
from
1b4dc49 to
0b420d9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Creation of EDAN verifier utility.