Add support for Jinja environment options in schemachange configuration.#227
Open
rosspb3 wants to merge 1 commit intoSnowflake-Labs:masterfrom
Open
Add support for Jinja environment options in schemachange configuration.#227rosspb3 wants to merge 1 commit intoSnowflake-Labs:masterfrom
rosspb3 wants to merge 1 commit intoSnowflake-Labs:masterfrom
Conversation
…achange configuration.
Collaborator
|
Hi @rosspb3, Thank you for this PR to add Jinja environment configuration options ( This PR has been open for about 2 years and likely has significant conflicts with the current codebase. We've also had other Jinja-related changes since then (including PR #353 for data injection). Questions:
If we don't hear back in the next few weeks, we may close this PR. You're welcome to reopen or create a new PR if you'd like to continue this work later. Thanks for your contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added ability to configure some Jinja Environment settings within the schemachange configuration via a new "jinja" section. This section would allow users to customize several parsing and rendering options in Jinja like
trim_blockslstrip_blocks,block_start_string,block_end_string,variable_start_string,variable_end_string, but disallows changing settings which could impact the behavior of schemachange likeundefined,loader,enable_async.