feat: validate change history table schema upfront, add ERROR_MESSAGE column#426
Open
luisggc wants to merge 1 commit intoSnowflake-Labs:masterfrom
Open
feat: validate change history table schema upfront, add ERROR_MESSAGE column#426luisggc wants to merge 1 commit intoSnowflake-Labs:masterfrom
luisggc wants to merge 1 commit intoSnowflake-Labs:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ERROR_MESSAGE VARCHARto theCREATE TABLEstatement so newly created change history tables include the column from the startvalidate_change_history_schema()called at initialization (after the table is confirmed to exist, before any scripts run), using a fast metadata-onlySELECT ERROR_MESSAGE FROM <table> LIMIT 0checkALTER TABLE ... ADD COLUMN IF NOT EXISTS ERROR_MESSAGE VARCHARautomaticallyrecord_change_historythat added the column on INSERT failureMotivation
Previously,
ERROR_MESSAGEwas added via auto-ALTER when an INSERT failed at runtime. This was risky: it introduced DDL mid-deploy, and if the role lacked ALTER privileges the deploy would break even for successful scripts (sinceerror_message=''is always passed). Moving this check to initialization gives a predictable, upfront failure instead.This is a prerequisite for the continue-on-error feature (#339).