fix: wire publicPolicy config through SDK#540
Merged
John-David Dalton (jdalton) merged 1 commit intomainfrom Apr 2, 2026
Merged
fix: wire publicPolicy config through SDK#540John-David Dalton (jdalton) merged 1 commit intomainfrom
John-David Dalton (jdalton) merged 1 commit intomainfrom
Conversation
John-David Dalton (jdalton)
force-pushed
the
fix/wire-public-policy-config
branch
from
cb11f18 to
c9efc8b
Compare
…rPublicPolicy The publicPolicy map was hardcoded in reshapeArtifactForPublicPolicy and checkMalwareFirewall, making it impossible for consumers to customize alert action resolution. This adds a publicPolicy option to SocketSdkOptions and wires it through all call sites: - reshapeArtifactForPublicPolicy now accepts an optional policy parameter (defaults to the built-in publicPolicy from constants) - SocketSdk stores the configured policy as #publicPolicy instance field - batchPackageStream, batchPackageFetch, and checkMalwareFirewall all pass the instance policy through
John-David Dalton (jdalton)
force-pushed
the
fix/wire-public-policy-config
branch
from
c9efc8b to
21844c4
Compare
Bill Li (billxinli)
approved these changes
Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
publicPolicyoption toSocketSdkOptionsso consumers can pass a custom alert policy mapreshapeArtifactForPublicPolicyto accept an optionalpolicyparameter (defaults to built-inpublicPolicyfrom constants)this.#publicPolicythrough all call sites:batchPackageStream,batchPackageFetch, andcheckMalwareFirewallThis was missed when merging #537 and #538 — the
publicPolicymap was hardcoded everywhere, making it impossible to customize alert action resolution.Test plan
pnpm build)pnpm run type)pnpm test)pnpm run lint)