Merge hotfix v1.3.1: allow lowercase letters in asset codes - #16
Merged
Conversation
Asset code validation rejected lowercase letters (a-z), preventing interaction with real mainnet assets like yUSDC and yETH. Align validation with the JS and Python Stellar SDKs by accepting alphanumeric characters (a-z, A-Z, 0-9) instead of uppercase only. - Update validateAssetCode regex to match JS/Python SDKs: ^[a-zA-Z0-9]+$ - Remove auto-uppercase transformations from demo app input fields - Update all documentation and help text referencing uppercase-only validation - Add XDR round-trip tests for lowercase asset codes Fixes #14
Hotfix release that corrects asset code validation to allow lowercase letters, matching the JS and Python Stellar SDK validation. - Fix asset code validation to accept alphanumeric characters (a-z, A-Z, 0-9) - Remove auto-uppercase transformations from demo app input fields - Update version numbers and documentation - Regenerate compatibility matrices Fixes #14
Codecov Report✅ All modified and coverable lines are covered by tests. ❌ Your project status has failed because the head coverage (77.33%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #16 +/- ##
==========================================
- Coverage 82.37% 77.33% -5.05%
==========================================
Files 806 836 +30
Lines 20505 24024 +3519
Branches 2650 3173 +523
==========================================
+ Hits 16892 18580 +1688
- Misses 2466 4164 +1698
- Partials 1147 1280 +133
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Merge the v1.3.1 hotfix into main. This brings the asset code validation fix and version updates from the hotfix branch.
Fixes #14