Skip to content

Merge hotfix v1.3.1: allow lowercase letters in asset codes - #16

Merged
christian-rogobete merged 2 commits into
mainfrom
hotfix/v1.3.1
Apr 3, 2026
Merged

Merge hotfix v1.3.1: allow lowercase letters in asset codes#16
christian-rogobete merged 2 commits into
mainfrom
hotfix/v1.3.1

Conversation

@christian-rogobete

Copy link
Copy Markdown
Member

Summary

Merge the v1.3.1 hotfix into main. This brings the asset code validation fix and version updates from the hotfix branch.

  • Fix asset code validation to accept alphanumeric characters (a-z, A-Z, 0-9), matching JS and Python Stellar SDKs
  • Remove auto-uppercase transformations from demo app input fields
  • Update documentation and compatibility matrices to v1.3.1

Fixes #14

Asset code validation rejected lowercase letters (a-z), preventing interaction with real mainnet assets like yUSDC and yETH. Align validation with the JS and Python Stellar SDKs by accepting alphanumeric characters (a-z, A-Z, 0-9) instead of uppercase only.

- Update validateAssetCode regex to match JS/Python SDKs: ^[a-zA-Z0-9]+$
- Remove auto-uppercase transformations from demo app input fields
- Update all documentation and help text referencing uppercase-only validation
- Add XDR round-trip tests for lowercase asset codes

Fixes #14
Hotfix release that corrects asset code validation to allow lowercase letters, matching the JS and Python Stellar SDK validation.

- Fix asset code validation to accept alphanumeric characters (a-z, A-Z, 0-9)
- Remove auto-uppercase transformations from demo app input fields
- Update version numbers and documentation
- Regenerate compatibility matrices

Fixes #14
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.33%. Comparing base (fc55079) to head (feb07ca).
⚠️ Report is 89 commits behind head on main.

❌ Your project status has failed because the head coverage (77.33%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #16      +/-   ##
==========================================
- Coverage   82.37%   77.33%   -5.05%     
==========================================
  Files         806      836      +30     
  Lines       20505    24024    +3519     
  Branches     2650     3173     +523     
==========================================
+ Hits        16892    18580    +1688     
- Misses       2466     4164    +1698     
- Partials     1147     1280     +133     
Files with missing lines Coverage Δ
.../commonMain/kotlin/com/soneso/stellar/sdk/Asset.kt 84.34% <100.00%> (-0.27%) ⬇️
...k/sep/sep38/exceptions/Sep38BadRequestException.kt 100.00% <ø> (ø)

... and 52 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@christian-rogobete
christian-rogobete merged commit b6e5179 into main Apr 3, 2026
5 checks passed
@christian-rogobete
christian-rogobete deleted the hotfix/v1.3.1 branch April 28, 2026 02:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Stellar Asset Code allows a to z

2 participants