[1131] Soroban contract and SDK feature SC-26 - #1204
Closed
Goodnessukaigwe wants to merge 1 commit into
Closed
Conversation
Allow admins to cap how many events an indexer can record per ledger across the Soroban contract, Django API, and Python/TypeScript SDKs/CLI. Co-authored-by: Cursor <cursoragent@cursor.com>
|
@Goodnessukaigwe Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
soroscan_core):set_indexer_rate_limit/get_indexer_rate_limit/get_indexer_rate_usagewithRateLimitExceededenforcement onrecord_event,record_events_batch, andrecord_structured_event. Passing0clears a limit. Also defines the missing SC-38DataKey/StructuredEventRecord/ error variants required for the crate to compile after the SC-38 merge.POST /api/ingest/indexers/rate-limit/andGET /api/ingest/indexers/<indexer>/rate-limit/plus Soroban client helpers.set_indexer_rate_limit/get_indexer_rate_limit(sync+async) andsoroscan indexers set-rate-limit|get-rate-limit; TypeScriptsetIndexerRateLimit/getIndexerRateLimit. Docs updated in contract/SDK READMEs andapi_reference.md.Closes #1131
Test plan
cargo test --libinsoroban-contracts/soroscan_core— 32/32 passing with pre-existing brokentest_event_decoding_and_typestemporarily excluded for local compile (left untouched in the PR; same pre-existing API drift noted in SC-30)TestIndexerRateLimitViews+ stellar_client rate-limit tests — 11 passedtests/test_sc26_*.py— 14 passedvitest run test/sc26-rate-limit.test.ts— 11 passedMade with Cursor