Build: Set FMLModType: GAMELIBRARY in manifest - #95
Merged
Conversation
This is necessary for (Neo)Forge to put Vigilance in the correct ClassLoader (namely one with access to UniversalCraft and therefore indirectly Minecraft). This should enable use of Vigilance in Forge development environments and even via jar-in-jar on 26.1+ NeoForge. Note: The attribute value required for this was changed from `LIBRARY` to `GAMELIBRARY` with ModLauncher 9 (Minecraft 1.17), so this won't work in a Forge for Minecraft 1.16 development environment. (see also SparkUniverse/UniversalCraft#104) Having it work on all versions would require we ship different jars for different versions, which I'd like to avoid. This should not affect usage of Vigilance in 1.16 Forge production environments, since jar-in-jar wasn't properly supported yet in 1.16, so you have to bundle and relocated Vigilance into your main mod jar anyway, and as such it will be loaded on the correct ClassLoader (the same one as your mod).
Traben-0
approved these changes
Apr 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See SparkUniverse/Elementa#178