SpiNNman simulation#333
Merged
Merged
Conversation
rowleya
approved these changes
Sep 29, 2025
Member
Author
|
Part of the work to run SpiNNman level simulations and lots of cleanup through a matching branch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: There is a parallel SpiNNManSimulation as it is tested by these prs.
This was motivate by SpiNNMan scripts not allowing but not needing a user cfg.
An alternative would have been to error only if required cfg stuff was missing,
But there are many different rules so this would need to be a delayed exception stored to call later
in this alternative the rule is IF there is a template a user cfg is required.
IE anything that depends on SpiNNFrontEndCommon
The addition is an extra slot value template and a add_template method to add it
The code then checks for it and acts differently if found.
While there there was some cleanup.
Code to look for a template replaced with use stored value
Code to find user cfg -simplified to find one, None or error
config_loader extra method to just load the defaults
config_loader load_config now takes the usercfg as a path not filename
config_holder now decides about the user cfg
test_conf_loader adapted accordingly
-@pytest.mark.xdist_group forces all these test to be run sequentially as they use a method that depends on global values
must be done at the same time as: