Skip to content

load configs from simulator#339

Merged
Christian-B merged 4 commits into
masterfrom
set_cfg_file_name
Nov 14, 2025
Merged

load configs from simulator#339
Christian-B merged 4 commits into
masterfrom
set_cfg_file_name

Conversation

@Christian-B

@Christian-B Christian-B commented Oct 24, 2025

Copy link
Copy Markdown
Member

This and related prs cleans up the loading of configs.

config_holder changes

  • simplifed untitest config loading to avoid other changes
  • standard load conig requires a template is set
  • load config not longer creates a template if there is no user config
    • This allows test with a local cfg to work without a user cfg
  • new check_user_cfg to be called if machine setup values are all None
    • his then creates the template
    • The exception if a template is created breaks out of the try three times loop
      = All default cfg path are added the same way
  • The Main/user cfg files to look for are directly passed into the load_config call

Adds an AbstractSpiNNManSimulation( class with 3 abstract methods

  • add_cfg_defaults_and_template
    • will call the local config_setup which finds the default files
    • Sets up the template file (now required)
    • So test and runs have defaults the same
  • user_cfg_file
    • Typically the same name as the default at this level but does not need to be
  • data_writer_cls
    • As there are now abstract methods no need to pass this all the way down

These allow for the simulator to load the configs and not depend on a previous call.

Spinnman.cfg.template added.

@Christian-B Christian-B requested a review from rowleya October 24, 2025 11:36
@Christian-B Christian-B changed the title load cofigs from config setuip classes load cofigs from config setup classes Oct 24, 2025
@Christian-B Christian-B changed the title load cofigs from config setup classes load configs from simulator Oct 29, 2025
@Christian-B Christian-B merged commit cc206ae into master Nov 14, 2025
25 checks passed
@Christian-B Christian-B deleted the set_cfg_file_name branch November 14, 2025 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants