Multi database#341
Closed
Christian-B wants to merge 15 commits into
Closed
Conversation
rowleya
approved these changes
Dec 8, 2025
rowleya
left a comment
Member
There was a problem hiding this comment.
Looks good - minor comment to fix if correct
| def __init__(self) -> None: | ||
| self._data_status: DataStatus = DataStatus.NOT_SETUP | ||
| self._executable_finder: ExecutableFinder = ExecutableFinder() | ||
| self._log_database_paths: Dict[str, Optional[str]] = {} |
Member
Author
There was a problem hiding this comment.
Yes. In this case the None represent that what was identified as the database key was invalid.
The alternatives where recheck the invalid key every time or worse have the Replacer fail on an invalid key.
Closed
Member
Author
|
needs changes in #343 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows for multiple logs databases.
replaces #340
LogSqlLiteDatabase track the keys they work for
DataView now holds the mapping between keys and paths
DataWriter clears the mapping of key to path on mock for easier testing
FileConvertor
Convert
Replacer
cfg changed as option not used at this level
tests