Skip to content

Use pyproject.toml#348

Merged
Christian-B merged 6 commits into
masterfrom
use_pyproject.toml
Jun 15, 2026
Merged

Use pyproject.toml#348
Christian-B merged 6 commits into
masterfrom
use_pyproject.toml

Conversation

@Christian-B

@Christian-B Christian-B commented May 22, 2026

Copy link
Copy Markdown
Member

Use pyyproject.toml

if this pr is approved it will be replicated without approval on most repositories.

tested with
https://github.com/SpiNNakerManchester/IntegrationTests/actions/runs/26281627917/job/77361823577

Note:
I had hoped to not repeat the version number but so far my attempts failed.

in pyproject.toml
[tool.setuptools.dynamic]
version = { attr = "spinn_utilities._version.version" }
gives:
configuration error: project must contain ['version'] properties

using
version = importlib.metadata.version("SpiNNUtilities")
cause various issues.

@Christian-B Christian-B requested a review from rowleya May 22, 2026 10:39

@rowleya rowleya left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable; note that the setup.sh script in SupportScripts will likely also need updating as I assume you can't do python setup.py install any more!

@Christian-B Christian-B mentioned this pull request May 28, 2026
@Christian-B Christian-B merged commit 869366d into master Jun 15, 2026
12 checks passed
@Christian-B Christian-B deleted the use_pyproject.toml branch June 15, 2026 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants