Refactor correctly handle empty response with ignore error flag is true - #1248
Merged
Conversation
| { | ||
| }; | ||
|
|
||
| string script = $@" |
Contributor
There was a problem hiding this comment.
Can you use "var"?
Contributor
Author
There was a problem hiding this comment.
type has been modified.
NoahHahm
force-pushed
the
script-nocontent
branch
from
August 28, 2025 06:40
a4513aa to
4b571e6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR handles cases where the body is empty, but the response is correct when ignore errors are enabled in the script.
The existing code causes a script parsing error when the body is passed to the JSON parser in ignore error mode.
reference
#1242 (comment)
unitycloud-rest-api