Feat/lut bias table!#9
Merged
Merged
Conversation
dbab302 to
beb3c56
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9 +/- ##
==========================================
- Coverage 72.12% 72.02% -0.10%
==========================================
Files 11 11
Lines 4814 5655 +841
Branches 4814 5655 +841
==========================================
+ Hits 3472 4073 +601
- Misses 1233 1454 +221
- Partials 109 128 +19 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New Lut based Bias table
The initial bias implementation used a hard cutoff that heavily suppressed k-mers from the negative set and unknown k-mers, retaining only the most significant positive-enriched signal. While this gave strong compression and clean extraction of target features, it tended to over-correct, particularly when the positive training set was sparse, producing sketches that only reflected the learned positive population rather than the broader sequence space. This branch replaces the hard cutoff with a Look-Up Table (LUT) that assigns an independent effective fscale to each of the 255 quantized weight buckets. This allows fine-grained control over retention across the full enrichment spectrum, including a dedicated fscale for weight-zero buckets (k-mers equally present in positive and negative sets, this included "not seen" kmers). The result is a sketch that remains informative for any input sequence, with varying sensitivity depending on the sequence's similarity to the positive and negative sets.
Changes