Conversation
Contributor
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Zahnentferner
approved these changes
Sep 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addressed Issues:
Frontend half of StabilityNexus/Fate-Solidity#43, which renamed the oracle read to the org-wide
IOracleinterface.Screenshots/Recordings:
Not applicable. ABI files and one call site; no visual change.
Additional Notes:
IOracle.tsnow carries the org interface:readValue,readValueInterval,lastUpdated,description.getLatestPriceandgetLatestRoundDataare removed from the interface ABI.ChainlinkOracle.tsandHebeswapOracle.tsrenamegetLatestPricetoreadValueand add the other three functions. Hebeswapdescriptionispure, Chainlink isview, matching the contracts.InteractionClient.tsxcallsreadValueinstead ofgetLatestPrice. It was the only call site.main(names, argument and return types, mutability, errors).Open question: Ethereum Classic mainnet (61) is in
addresses.tsbut is not on the redeploy list. After this merges,readValuereverts on ETC pools. Two options:addresses.tsuntil the new contract set is deployed there.readValue->getLatestPricefallback at theInteractionClientcall site for chains still on the old oracles.This stays a draft until the Sepolia redeploy with the final contract set lands and that question is answered.
AI Usage Disclosure:
We encourage contributors to use AI tools responsibly when creating Pull Requests. While AI can be a valuable aid, it is essential to ensure that your contributions meet the task requirements, build successfully, include relevant tests, and pass all linters. Submissions that do not meet these standards may be closed without warning to maintain the quality and integrity of the project. Please take the time to understand the changes you are proposing and their impact. AI slop is strongly discouraged and may lead to banning and blocking. Do not spam our repos with AI slop.
Check one of the checkboxes below:
I have used the following AI models and tools: Claude Code (Claude Fable 5.1)
Checklist