Skip to content

Adopt the org-wide IOracle ABI - #135

Draft
rohans02 wants to merge 1 commit into
StabilityNexus:mainfrom
rohans02:feat/org-ioracle-interface
Draft

rohans02 wants to merge 1 commit into
StabilityNexus:mainfrom
rohans02:feat/org-ioracle-interface

Conversation

@rohans02

@rohans02 rohans02 commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

Addressed Issues:

Frontend half of StabilityNexus/Fate-Solidity#43, which renamed the oracle read to the org-wide IOracle interface.

Screenshots/Recordings:

Not applicable. ABI files and one call site; no visual change.

Additional Notes:

  • IOracle.ts now carries the org interface: readValue, readValueInterval, lastUpdated, description. getLatestPrice and getLatestRoundData are removed from the interface ABI.
  • ChainlinkOracle.ts and HebeswapOracle.ts rename getLatestPrice to readValue and add the other three functions. Hebeswap description is pure, Chainlink is view, matching the contracts.
  • InteractionClient.tsx calls readValue instead of getLatestPrice. It was the only call site.
  • Every entry in the three ABI files was checked against the Solidity sources on main (names, argument and return types, mutability, errors).

Open question: Ethereum Classic mainnet (61) is in addresses.ts but is not on the redeploy list. After this merges, readValue reverts on ETC pools. Two options:

  1. Drop 61 from addresses.ts until the new contract set is deployed there.
  2. Keep a readValue -> getLatestPrice fallback at the InteractionClient call site for chains still on the old oracles.

This stays a draft until the Sepolia redeploy with the final contract set lands and that question is answered.

AI Usage Disclosure:

We encourage contributors to use AI tools responsibly when creating Pull Requests. While AI can be a valuable aid, it is essential to ensure that your contributions meet the task requirements, build successfully, include relevant tests, and pass all linters. Submissions that do not meet these standards may be closed without warning to maintain the quality and integrity of the project. Please take the time to understand the changes you are proposing and their impact. AI slop is strongly discouraged and may lead to banning and blocking. Do not spam our repos with AI slop.

Check one of the checkboxes below:

  • This PR does not contain AI-generated code at all.
  • This PR contains AI-generated code. I have read the AI Usage Policy and this PR complies with this policy. I have tested the code locally and I am responsible for it.

I have used the following AI models and tools: Claude Code (Claude Fable 5.1)

Checklist

  • My PR addresses a single issue, fixes a single bug or makes a single improvement.
  • My code follows the project's code style and conventions
  • If applicable, I have made corresponding changes or additions to the documentation
  • If applicable, I have made corresponding changes or additions to tests
  • My changes generate no new warnings or errors
  • I have joined the Discord server and I will share a link to this PR with the project maintainers there
  • I have read the Contribution Guidelines
  • Once I submit my PR, CodeRabbit AI will automatically review it and I will address CodeRabbit's comments.
  • I have filled this PR template completely and carefully, and I understand that my PR may be closed without review otherwise.

@coderabbitai

coderabbitai Bot commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants