[BugFix] fix mem leak when caching mv plan context by kaijianding · Pull Request #72300 · StarRocks/starrocks

kaijianding · 2026-04-28T15:35:11Z

Why I'm doing:

There are lots of LakeTablet object on FOLLOWER after frequently drop&create same materialized view.
And objects can't be releazed after fe transfers to LEADER.

 num     #instances         #bytes  class name (module)
-------------------------------------------------------
   1:      24469095     1080226352  [B (java.base@17.0.2)
   2:      13197226     1055778080  com.starrocks.lake.LakeTablet

What I'm doing:

Removed dropped materialized view object from pending cache and double check materialized view still exists before be added to context cache.

Fixes #issue

What type of PR is this:

Does this PR entail a change in behavior?

Yes, this PR will result in a change in behavior.
No, this PR will not result in a change in behavior.

Checklist:

I have added test cases for my bug fix or my new feature
This pr needs user documentation (for new or modified features or behaviors)
- I have added documentation for my new feature or new function
- This pr needs auto generate documentation
This is a backport pr

Bugfix cherry-pick branch check:

CelerData-Reviewer · 2026-04-28T15:36:21Z

@codex review

chatgpt-codex-connector · 2026-04-28T15:40:33Z

Codex Review: Didn't find any major issues. Keep it up!

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Signed-off-by: kaijian.ding <kaijian.ding@gmail.com>

CelerData-Reviewer · 2026-04-29T03:29:19Z

@codex review

Copilot

Pull request overview

Fixes a FE-side memory leak where dropped materialized views could remain referenced via the MV plan-context pending cache during replay/startup, causing stale/heavy MV objects to be retained and potentially loaded into the context cache later.

Changes:

Remove evicted/dropped MVs from MV_PLAN_CACHE_PENDING during evictMaterializedViewCache().
When triggering pending loads, re-fetch MV metadata from LocalMetastore and skip loading if the MV no longer exists.
Add regression tests covering pending-cache eviction and replay “pending load after drop” scenarios.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File	Description
fe/fe-core/src/main/java/com/starrocks/sql/optimizer/CachingMvPlanContextBuilder.java	Ensures dropped MVs don’t linger in pending cache; avoids loading stale pending entries by re-validating against metastore.
fe/fe-core/src/test/java/com/starrocks/planner/MaterializedViewTextBasedRewriteTest.java	Adds regression tests to prevent reintroducing pending-cache retention and stale-load issues.

chatgpt-codex-connector · 2026-04-29T03:33:05Z

Codex Review: Didn't find any major issues. Bravo.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Signed-off-by: kaijian.ding <kaijian.ding@gmail.com>

github-actions · 2026-04-29T04:50:41Z

[Java-Extensions Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

github-actions · 2026-04-29T04:51:38Z

[FE Incremental Coverage Report]

✅ pass : 9 / 9 (100.00%)

file detail

	path	covered_line	new_line	coverage	not_covered_line_detail
🔵	com/starrocks/sql/optimizer/CachingMvPlanContextBuilder.java	9	9	100.00%	[]

github-actions · 2026-04-29T04:52:28Z

[BE Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

github-actions · 2026-04-30T06:04:49Z

@Mergifyio backport branch-4.1

github-actions · 2026-04-30T06:04:50Z

@Mergifyio backport branch-3.5

github-actions · 2026-04-30T06:04:50Z

@Mergifyio backport branch-4.0

mergify · 2026-04-30T06:04:54Z

backport branch-4.1

✅ Backports have been created

Details

#72388 [BugFix] fix mem leak when caching mv plan context (backport #72300) has been created for branch branch-4.1

mergify · 2026-04-30T06:04:55Z

backport branch-3.5

✅ Backports have been created

Details

#72389 [BugFix] fix mem leak when caching mv plan context (backport #72300) has been created for branch branch-3.5 but encountered conflicts

Cherry-pick of 33ccc4a has failed:

On branch mergify/bp/branch-3.5/pr-72300
Your branch is up to date with 'origin/branch-3.5'.

You are currently cherry-picking commit 33ccc4ae03.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   fe/fe-core/src/main/java/com/starrocks/sql/optimizer/CachingMvPlanContextBuilder.java

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   fe/fe-core/src/test/java/com/starrocks/planner/MaterializedViewTextBasedRewriteTest.java

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

mergify · 2026-04-30T06:04:56Z

backport branch-4.0

✅ Backports have been created

Details

#72390 [BugFix] fix mem leak when caching mv plan context (backport #72300) has been created for branch branch-4.0 but encountered conflicts

Cherry-pick of 33ccc4a has failed:

On branch mergify/bp/branch-4.0/pr-72300
Your branch is up to date with 'origin/branch-4.0'.

You are currently cherry-picking commit 33ccc4ae03.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   fe/fe-core/src/main/java/com/starrocks/sql/optimizer/CachingMvPlanContextBuilder.java

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   fe/fe-core/src/test/java/com/starrocks/planner/MaterializedViewTextBasedRewriteTest.java

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

Signed-off-by: kaijian.ding <kaijian.ding@gmail.com>

Signed-off-by: kaijian.ding <kaijian.ding@gmail.com> Signed-off-by: xiangguangyxg <xiangguangyxg@gmail.com>

…72388) Signed-off-by: kaijian.ding <kaijian.ding@gmail.com> Co-authored-by: kaijianding <kaijian.ding@gmail.com>

…72390) Co-authored-by: kaijianding <kaijian.ding@gmail.com> Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: kevincai <771299+kevincai@users.noreply.github.com>

…72389) Signed-off-by: Kevin Cai <kevin.cai@celerdata.com> Co-authored-by: kaijianding <kaijian.ding@gmail.com> Co-authored-by: Kevin Cai <kevin.cai@celerdata.com>

…(backport #72389) (#73091) Signed-off-by: Kevin Cai <kevin.cai@celerdata.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Co-authored-by: kaijianding <kaijian.ding@gmail.com> Co-authored-by: Kevin Cai <kevin.cai@celerdata.com>

kaijianding requested a review from a team as a code owner April 28, 2026 15:35

github-actions Bot added 3.5 4.1 4.0 labels Apr 28, 2026

mergify Bot assigned kaijianding Apr 28, 2026

github-actions Bot requested a review from HangyuanLiu April 28, 2026 15:38

[BugFix] fix mem leak when caching mv plan context

fb9ea02

Signed-off-by: kaijian.ding <kaijian.ding@gmail.com>

kevincai requested review from Copilot and kevincai April 29, 2026 03:25

kevincai previously approved these changes Apr 29, 2026

View reviewed changes

Copilot started reviewing on behalf of kevincai April 29, 2026 03:26 View session

kaijianding dismissed kevincai’s stale review via 4f0f259 April 29, 2026 03:28

kaijianding force-pushed the pending_cache_leak branch from a8bf6c2 to 4f0f259 Compare April 29, 2026 03:28

Copilot AI reviewed Apr 29, 2026

View reviewed changes

Comment thread fe/fe-core/src/test/java/com/starrocks/planner/MaterializedViewTextBasedRewriteTest.java Outdated

Comment thread fe/fe-core/src/test/java/com/starrocks/planner/MaterializedViewTextBasedRewriteTest.java Outdated

kaijianding force-pushed the pending_cache_leak branch from 4f0f259 to 112bdfc Compare April 29, 2026 03:34

add more ut

17f17bf

Signed-off-by: kaijian.ding <kaijian.ding@gmail.com>

kaijianding force-pushed the pending_cache_leak branch from 112bdfc to 17f17bf Compare April 29, 2026 03:42

kevincai approved these changes Apr 29, 2026

View reviewed changes

Wenjun7J reviewed Apr 29, 2026

View reviewed changes

Comment thread fe/fe-core/src/main/java/com/starrocks/sql/optimizer/CachingMvPlanContextBuilder.java

Wenjun7J approved these changes Apr 29, 2026

View reviewed changes

satanson approved these changes Apr 30, 2026

View reviewed changes

satanson enabled auto-merge (squash) April 30, 2026 03:37

HangyuanLiu approved these changes Apr 30, 2026

View reviewed changes

stephen-shelby approved these changes Apr 30, 2026

View reviewed changes

satanson merged commit 33ccc4a into StarRocks:main Apr 30, 2026
70 checks passed

github-actions Bot removed 4.1 3.5 4.0 labels Apr 30, 2026

This was referenced Apr 30, 2026

[BugFix] fix mem leak when caching mv plan context (backport #72300) #72388

Merged

[BugFix] fix mem leak when caching mv plan context (backport #72300) #72389

Merged

[BugFix] fix mem leak when caching mv plan context (backport #72300) #72390

Merged

robd003 pushed a commit to robd003/starrocks that referenced this pull request May 6, 2026

[BugFix] fix mem leak when caching mv plan context (StarRocks#72300)

b0aa2f9

Signed-off-by: kaijian.ding <kaijian.ding@gmail.com>

kaijianding deleted the pending_cache_leak branch May 6, 2026 11:34

xiangguangyxg pushed a commit to xiangguangyxg/starrocks that referenced this pull request May 7, 2026

[BugFix] fix mem leak when caching mv plan context (StarRocks#72300)

16a40ba

Signed-off-by: kaijian.ding <kaijian.ding@gmail.com> Signed-off-by: xiangguangyxg <xiangguangyxg@gmail.com>

wanpengfei-git pushed a commit that referenced this pull request May 8, 2026

[BugFix] fix mem leak when caching mv plan context (backport #72300) (#…

4130a2a

…72388) Signed-off-by: kaijian.ding <kaijian.ding@gmail.com> Co-authored-by: kaijianding <kaijian.ding@gmail.com>

github-actions Bot added the 4.1-merged label May 8, 2026

github-actions Bot added the 4.0-merged label May 8, 2026

github-actions Bot added the 3.5-merged label May 9, 2026

mergify Bot mentioned this pull request May 11, 2026

[BugFix] fix mem leak when caching mv plan context (backport #72300) (backport #72389) #73091

Merged

19 tasks

Uh oh!

Conversation

kaijianding commented Apr 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Why I'm doing:

What I'm doing:

What type of PR is this:

Checklist:

Bugfix cherry-pick branch check:

Uh oh!

CelerData-Reviewer commented Apr 28, 2026

Uh oh!

chatgpt-codex-connector Bot commented Apr 28, 2026

Uh oh!

CelerData-Reviewer commented Apr 29, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connector Bot commented Apr 29, 2026

Uh oh!

github-actions Bot commented Apr 29, 2026

[Java-Extensions Incremental Coverage Report]

Uh oh!

github-actions Bot commented Apr 29, 2026

[FE Incremental Coverage Report]

file detail

Uh oh!

github-actions Bot commented Apr 29, 2026

[BE Incremental Coverage Report]

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Apr 30, 2026

Uh oh!

github-actions Bot commented Apr 30, 2026

Uh oh!

github-actions Bot commented Apr 30, 2026

Uh oh!

mergify Bot commented Apr 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Backports have been created

Uh oh!

mergify Bot commented Apr 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Backports have been created

Uh oh!

mergify Bot commented Apr 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Backports have been created

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

kaijianding commented Apr 28, 2026 •

edited

Loading

mergify Bot commented Apr 30, 2026 •

edited

Loading

mergify Bot commented Apr 30, 2026 •

edited

Loading

mergify Bot commented Apr 30, 2026 •

edited

Loading