[BugFix] Cast COALESCE children to common type in JOIN USING transformer by Hyper-FF · Pull Request #72338 · StarRocks/starrocks

Hyper-FF · 2026-04-29T08:33:40Z

Why I'm doing:

createCoalesceOperator resolved a common result type for the synthesized USING-projection COALESCE but passed the original left/right operands as children without casting, so the call's actual child types could disagree with the resolved function signature (e.g. DATETIME child under a coalesce(VARCHAR) signature). Wrap children whose type differs from the common type in an implicit CAST and look up the function with {commonType, commonType} so the signature is consistent.

What I'm doing:

Fixes #issue

What type of PR is this:

Does this PR entail a change in behavior?

Yes, this PR will result in a change in behavior.
No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

Interface/UI changes: syntax, type conversion, expression evaluation, display information
Parameter changes: default values, similar parameters but with different default values
Policy changes: use new policy to replace old one, functionality automatically enabled
Feature removed
Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

I have added test cases for my bug fix or my new feature
This pr needs user documentation (for new or modified features or behaviors)
- I have added documentation for my new feature or new function
- This pr needs auto generate documentation
This is a backport pr

Bugfix cherry-pick branch check:

createCoalesceOperator resolved a common result type for the synthesized USING-projection COALESCE but passed the original left/right operands as children without casting, so the call's actual child types could disagree with the resolved function signature (e.g. DATETIME child under a coalesce(VARCHAR) signature). Wrap children whose type differs from the common type in an implicit CAST and look up the function with {commonType, commonType} so the signature is consistent.

CelerData-Reviewer · 2026-04-29T08:34:48Z

@codex review

chatgpt-codex-connector · 2026-04-29T08:37:38Z

Codex Review: Didn't find any major issues. 👍

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Covers the planner fix for createCoalesceOperator: USING-named columns that have DATETIME on one side and VARCHAR on the other must be wrapped in an explicit CAST to the resolved common type so the synthesized COALESCE has well-typed children. Verifies the queries do not error out and that match / outer-row counts are correct.

Signed-off-by: Hyper-FF <253014618+Hyper-FF@users.noreply.github.com>

CLAassistant · 2026-04-29T13:40:33Z

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

CelerData-Reviewer · 2026-04-29T13:42:03Z

@codex review

chatgpt-codex-connector · 2026-04-29T13:46:11Z

Codex Review: Didn't find any major issues. Chef's kiss.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

github-actions · 2026-04-29T14:22:00Z

[Java-Extensions Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

github-actions · 2026-04-29T14:22:56Z

[FE Incremental Coverage Report]

✅ pass : 6 / 6 (100.00%)

file detail

	path	covered_line	new_line	coverage	not_covered_line_detail
🔵	com/starrocks/sql/optimizer/transformer/RelationTransformer.java	6	6	100.00%	[]

github-actions · 2026-04-29T14:25:21Z

[BE Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

github-actions · 2026-04-30T02:26:20Z

@Mergifyio backport branch-4.0

github-actions · 2026-04-30T02:26:21Z

@Mergifyio backport branch-4.1

mergify · 2026-04-30T02:26:25Z

backport branch-4.0

✅ Backports have been created

Details

#72371 [BugFix] Cast COALESCE children to common type in JOIN USING transformer (backport #72338) has been created for branch branch-4.0 but encountered conflicts

Cherry-pick of cb2fd87 has failed:

On branch mergify/bp/branch-4.0/pr-72338
Your branch is up to date with 'origin/branch-4.0'.

You are currently cherry-picking commit cb2fd87fcb.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   fe/fe-core/src/test/java/com/starrocks/sql/plan/JoinTest.java
	new file:   test/sql/test_join/R/test_full_outer_join_using_mismatched_types.sql
	new file:   test/sql/test_join/T/test_full_outer_join_using_mismatched_types.sql

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   fe/fe-core/src/main/java/com/starrocks/sql/optimizer/transformer/RelationTransformer.java

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

mergify · 2026-04-30T02:26:26Z

backport branch-4.1

✅ Backports have been created

Details

#72372 [BugFix] Cast COALESCE children to common type in JOIN USING transformer (backport #72338) has been created for branch branch-4.1

…mer (backport #72338) (#72371) Signed-off-by: stdpain <34912776+stdpain@users.noreply.github.com> Co-authored-by: Hyper-FF <253014618+Hyper-FF@users.noreply.github.com> Co-authored-by: stdpain <34912776+stdpain@users.noreply.github.com>

…mer (backport #72338) (#72372) Signed-off-by: Hyper-FF <253014618+Hyper-FF@users.noreply.github.com> Co-authored-by: Hyper-FF <253014618+Hyper-FF@users.noreply.github.com> Co-authored-by: Claude <noreply@anthropic.com>

…mer (StarRocks#72338) Signed-off-by: Hyper-FF <253014618+Hyper-FF@users.noreply.github.com> Co-authored-by: Claude <noreply@anthropic.com>

…mer (StarRocks#72338) Signed-off-by: Hyper-FF <253014618+Hyper-FF@users.noreply.github.com> Co-authored-by: Claude <noreply@anthropic.com> Signed-off-by: xiangguangyxg <xiangguangyxg@gmail.com>

Hyper-FF requested a review from a team as a code owner April 29, 2026 08:33

github-actions Bot added 4.0 4.1 labels Apr 29, 2026

mergify Bot assigned Hyper-FF Apr 29, 2026

github-actions Bot requested a review from satanson April 29, 2026 08:36

claude and others added 2 commits April 29, 2026 09:17

Update JoinTest.java

3d5d0a6

Signed-off-by: Hyper-FF <253014618+Hyper-FF@users.noreply.github.com>

Seaven approved these changes Apr 30, 2026

View reviewed changes

stdpain approved these changes Apr 30, 2026

View reviewed changes

stdpain merged commit cb2fd87 into StarRocks:main Apr 30, 2026
55 of 57 checks passed

github-actions Bot removed 4.0 4.1 labels Apr 30, 2026

This was referenced Apr 30, 2026

[BugFix] Cast COALESCE children to common type in JOIN USING transformer (backport #72338) #72371

Merged

[BugFix] Cast COALESCE children to common type in JOIN USING transformer (backport #72338) #72372

Merged

github-actions Bot added the 4.0-merged label Apr 30, 2026

github-actions Bot added the 4.1-merged label Apr 30, 2026

Uh oh!

Conversation

Hyper-FF commented Apr 29, 2026

Why I'm doing:

What I'm doing:

What type of PR is this:

Checklist:

Bugfix cherry-pick branch check:

Uh oh!

CelerData-Reviewer commented Apr 29, 2026

Uh oh!

chatgpt-codex-connector Bot commented Apr 29, 2026

Uh oh!

CLAassistant commented Apr 29, 2026

Uh oh!

CelerData-Reviewer commented Apr 29, 2026

Uh oh!

chatgpt-codex-connector Bot commented Apr 29, 2026

Uh oh!

github-actions Bot commented Apr 29, 2026

[Java-Extensions Incremental Coverage Report]

Uh oh!

github-actions Bot commented Apr 29, 2026

[FE Incremental Coverage Report]

file detail

Uh oh!

github-actions Bot commented Apr 29, 2026

[BE Incremental Coverage Report]

Uh oh!

Uh oh!

github-actions Bot commented Apr 30, 2026

Uh oh!

github-actions Bot commented Apr 30, 2026

Uh oh!

mergify Bot commented Apr 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Backports have been created

Uh oh!

mergify Bot commented Apr 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Backports have been created

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

mergify Bot commented Apr 30, 2026 •

edited

Loading

mergify Bot commented Apr 30, 2026 •

edited

Loading