Skip to content

[Enhancement] Introduce SCHEDULE keyword as ASYNC synonym for MV refresh (backport #72329)#72344

Merged
wanpengfei-git merged 1 commit into
branch-4.1from
mergify/bp/branch-4.1/pr-72329
Apr 29, 2026
Merged

[Enhancement] Introduce SCHEDULE keyword as ASYNC synonym for MV refresh (backport #72329)#72344
wanpengfei-git merged 1 commit into
branch-4.1from
mergify/bp/branch-4.1/pr-72329

Conversation

@mergify

@mergify mergify Bot commented Apr 29, 2026

Copy link
Copy Markdown
Contributor

Why I'm doing:

What I'm doing:

the trigger framework keyword for scheduled refresh is renamed to SCHEDULE. ASYNC is preserved as a parser-level synonym so existing scripts continue to work; SHOW CREATE displays the new SCHEDULE keyword.

Production:

  • Grammar: refreshSchemeDesc now accepts (ASYNC | SCHEDULE) as equivalent tokens for the scheduled refresh form. Both keywords are already declared in the lexer and listed as non-reserved.
  • AstBuilder.visitRefreshSchemeDesc: branch on ASYNC || SCHEDULE; both produce the same AsyncRefreshSchemeDesc.
  • MaterializedView.getMaterializedViewDdlStmt: emit "SCHEDULE" in place of "ASYNC" for MaterializedViewRefreshType.ASYNC. The persisted enum is unchanged; only the user-facing display is updated.

Tests:

  • Add a synonym test (testAsyncIsSynonymForScheduleAndShowCreatePrefers Schedule) covering both keywords in CREATE and asserting SHOW CREATE output uses SCHEDULE.
  • Update the parameterized refreshArgumentsList in ShowCreateMaterializedViewStmtTest from REFRESH ASYNC to REFRESH SCHEDULE so the SHOW CREATE round-trip assertion matches the new display.
  • Update testAlterRefreshScheme to translate ASYNC→SCHEDULE when comparing the SHOW CREATE output of an ALTER REFRESH ASYNC ... statement.
  • Update SQL integration R files where SHOW CREATE output appears (test_enable_mv, test_random_distribution) to expect SCHEDULE.

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
    • This pr needs auto generate documentation
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 4.1
    • 4.0
    • 3.5
    • 3.4

This is an automatic backport of pull request #72329 done by [Mergify](https://mergify.com).

@mergify

mergify Bot commented Apr 29, 2026

Copy link
Copy Markdown
Contributor Author

Cherry-pick of 112df75 has failed:

On branch mergify/bp/branch-4.1/pr-72329
Your branch is up to date with 'origin/branch-4.1'.

You are currently cherry-picking commit 112df75c36.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   docs/en/sql-reference/sql-statements/materialized_view/ALTER_MATERIALIZED_VIEW.md
	modified:   docs/en/sql-reference/sql-statements/materialized_view/CREATE_MATERIALIZED_VIEW.md
	modified:   docs/ja/sql-reference/sql-statements/materialized_view/ALTER_MATERIALIZED_VIEW.md
	modified:   docs/ja/sql-reference/sql-statements/materialized_view/CREATE_MATERIALIZED_VIEW.md
	modified:   docs/zh/sql-reference/sql-statements/materialized_view/ALTER_MATERIALIZED_VIEW.md
	modified:   docs/zh/sql-reference/sql-statements/materialized_view/CREATE_MATERIALIZED_VIEW.md
	modified:   fe/fe-core/src/main/java/com/starrocks/catalog/MaterializedView.java
	modified:   fe/fe-core/src/main/java/com/starrocks/sql/parser/AstBuilder.java
	modified:   fe/fe-core/src/test/java/com/starrocks/analysis/AlterMaterializedViewTest.java
	modified:   fe/fe-core/src/test/java/com/starrocks/analysis/ShowCreateMaterializedViewStmtTest.java

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   fe/fe-grammar/src/main/antlr/com/starrocks/grammar/StarRocks.g4

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@mergify mergify Bot added the conflicts label Apr 29, 2026
@github-actions github-actions Bot added documentation Documentation changes automerge labels Apr 29, 2026
@wanpengfei-git wanpengfei-git enabled auto-merge (squash) April 29, 2026 09:06
@mergify mergify Bot closed this Apr 29, 2026
auto-merge was automatically disabled April 29, 2026 09:06

Pull request was closed

@mergify

mergify Bot commented Apr 29, 2026

Copy link
Copy Markdown
Contributor Author

@mergify[bot]: Backport conflict, please reslove the conflict and resubmit the pr

@Youngwb Youngwb reopened this Apr 29, 2026
@wanpengfei-git wanpengfei-git enabled auto-merge (squash) April 29, 2026 10:59
…esh (#72329)

Signed-off-by: Youngwb <yangwenbo_mailbox@163.com>
Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
(cherry picked from commit 112df75)
@Youngwb Youngwb force-pushed the mergify/bp/branch-4.1/pr-72329 branch from 9471494 to 644ae60 Compare April 29, 2026 11:16
@github-actions

Copy link
Copy Markdown
Contributor

🌎 Translation Required?

All translation files are up to date.
Great job! No translation actions are required for this PR.

🕒 Last updated: Wed, 29 Apr 2026 11:23:15 GMT

@wanpengfei-git wanpengfei-git merged commit 0115f2e into branch-4.1 Apr 29, 2026
31 checks passed
@wanpengfei-git wanpengfei-git deleted the mergify/bp/branch-4.1/pr-72329 branch April 29, 2026 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants