[BugFix] Add variant to non reserved keywords#72356
Merged
alvin-phoenix-ai merged 1 commit intoApr 29, 2026
Merged
Conversation
Signed-off-by: kyle-goodale-klaviyo <kyle.goodale@klaviyo.com>
kyle-goodale-klaviyo
changed the title
kyle-goodale-klaviyo
changed the title
|
@codex review |
|
Codex Review: Didn't find any major issues. Keep them coming! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Contributor
[Java-Extensions Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
Contributor
[FE Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
Contributor
[BE Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
alvin-phoenix-ai
approved these changes
Apr 29, 2026
Contributor
|
@Mergifyio backport branch-4.1 |
Contributor
✅ Backports have been createdDetails
|
24 tasks
wanpengfei-git
pushed a commit
that referenced
this pull request
Apr 29, 2026
Hyper-FF
pushed a commit
to Hyper-FF/starrocks
that referenced
this pull request
Apr 30, 2026
Signed-off-by: kyle-goodale-klaviyo <kyle.goodale@klaviyo.com>
robd003
pushed a commit
to robd003/starrocks
that referenced
this pull request
May 6, 2026
Signed-off-by: kyle-goodale-klaviyo <kyle.goodale@klaviyo.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why I'm doing:
The new Variant type is not listed as a non reserved keyword like all the other type keywords. Because of this, we were encountering parsing errors when materialized views ran that had a struct field named
Variant. This issue persisted in created materialized views and surfaced when they ran not on creation. The issue remained even when we escaped the word variant with backticks.What I'm doing:
This PR adds variant as a non-reserved keyword. This fixed the issue for us.
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check: