Skip to content

[BugFix] Python inline UDF creation failing when file='inline' is omitted #72359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stdpain merged 2 commits into from
Apr 30, 2026
Merged

[BugFix] Python inline UDF creation failing when file='inline' is omitted #72359

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
560863b
Fix inline Python UDF creation failing when file='inline' is omitted
s4ch1n Apr 29, 2026
14708fc
Merge branch 'main' into pyudffix
stdpain Apr 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions fe/fe-core/src/main/java/com/starrocks/sql/analyzer/CreateFunctionAnalyzer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -781,14 +781,11 @@ private void analyzePython(CreateFunctionStmt stmt, ConnectContext context) {
}
String symbol = properties.get(CreateFunctionStmt.SYMBOL_KEY);
String inputType = properties.getOrDefault(CreateFunctionStmt.INPUT_TYPE, "scalar");
String objectFile = stmt.getProperties().get(CreateFunctionStmt.FILE_KEY);
String objectFile = properties.getOrDefault(CreateFunctionStmt.FILE_KEY, "inline");

if (isInline && !StringUtils.equalsIgnoreCase(objectFile, "inline")) {
ErrorReport.reportSemanticException(ErrorCode.ERR_COMMON_ERROR, "inline function file should be 'inline'");
Comment thread
stdpain marked this conversation as resolved.
}
if (isInline) {
objectFile = "inline";
}

if (!inputType.equalsIgnoreCase("arrow") && !inputType.equalsIgnoreCase("scalar")) {
ErrorReport.reportSemanticException(ErrorCode.ERR_COMMON_ERROR, "unknown input type:" + inputType);
Expand Down
22 changes: 22 additions & 0 deletions fe/fe-core/src/test/java/com/starrocks/sql/analyzer/CreateFunctionStmtAnalyzerTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,20 @@ private CreateFunctionStmt createPyStmt(String symbol, String type, String targe
createFunctionSql, 32).get(0);
}

private CreateFunctionStmt createPyInlineStmtNoFile(String symbol) {
Config.enable_udf = true;
String createFunctionSql = String.format("CREATE FUNCTION ABC.MY_UDF_JSON_GET_NOFILE(string, string) \n"
+ "RETURNS string \n"
+ "type = 'Python'\n"
+ "symbol = '%s'\n"
+ "AS $$\n"
+ "def a(b):\n"
+ " return b\n"
+ "$$;", symbol);
return (CreateFunctionStmt) com.starrocks.sql.parser.SqlParser.parse(
createFunctionSql, 32).get(0);
}

@Test
public void testJUDF() {
assertThrows(Throwable.class, () -> {
Expand Down Expand Up @@ -1116,6 +1130,14 @@ public void testJScalarUDFArrayOfStruct() {
});
}

@Test
public void testPyInlineUDFWithoutFileProperty() {
CreateFunctionStmt stmt = createPyInlineStmtNoFile("a");
Assertions.assertNotNull(stmt.getContent(), "Inline body must be parsed into content");
new CreateFunctionAnalyzer().analyze(stmt, connectContext);
Assertions.assertEquals("inline", stmt.getFunction().getLocation().toString(),
"Analyzer must auto-set location to 'inline' when file property is omitted");
}
public static class DateEval {
public java.time.LocalDateTime evaluate(java.time.LocalDate d, java.time.LocalDateTime ts) {
return ts;
Expand Down
Loading